backdrop-contrib / views_bootstrap

This module provides a set of styles for the Views module. It allows you to create responsive Bootstrap 3.x components, such as grids, carousels, tabs, and tables, all within the configuration settings of the powerful Views module.

https://backdropcms.org/project/views_bootstrap

GNU General Public License v2.0

0 stars 7 forks source link

Changes to address PHP missing file warnings #26

Closed daggerhart closed 5 years ago

daggerhart commented 5 years ago

Updated 'path' declarations to point towards the each plugin's unique folder.
Added 'theme file' declarations to each plugin. These are relative to the plugin's "path" declaration. (see _theme_process_registry())
Removed duplicate template_preprocess_* functions from the .module file. The functions in theme.inc are loaded when the style is used.

Not sure if this is the "best" way to do this, but it seemed to be the easiest way to solve the PHP warnings problem without moving the plugin files.

daggerhart commented 5 years ago

11

stpaultim commented 5 years ago

@daggerhart - Thanks much for this PR. I am curious if you are actually using this module OR did you just reply to my request for help with this issue.

I've looked it over and tested it on two sites and it seems to work as expected.

daggerhart commented 5 years ago

I was replying to your request for help on twitter. Unfortunately I still haven't had much opportunity to use backdrop. I enjoy learning about it and helping out when I can, but don't have BD any clients at the moment.