search

backdrop-contrib / views_bootstrap

This module provides a set of styles for the Views module. It allows you to create responsive Bootstrap 3.x components, such as grids, carousels, tabs, and tables, all within the configuration settings of the powerful Views module.
https://backdropcms.org/project/views_bootstrap
GNU General Public License v2.0
0 stars 7 forks source link

Discussion about change to settings #33

Closed stpaultim closed 5 years ago

stpaultim commented 5 years ago

Just noticed that in the last version of the module, the user had the ability to load bootstrap on all pages or ONLY on specific pages, user could list whichever pages they wanted.

With this pull request (https://github.com/backdrop-contrib/views_bootstrap/issues/28), we changed that to only allow the user to check or not to check "Include Bootstrap CSS & JS when used by Views."

Is there any loss in functionality there? Is is a problem?

NOTE: I am not clear if this is a problem. I just created this issue to see if anyone else thinks it might be a problem. I think the change is probably fine, unless it is what is responsible for causing the module to NOT work in views preview.

Radcliffe commented 5 years ago

I think that there is a problem.

Several issues were reported regarding conflicts between Bootstrap and the admin theme. These issues were resolved in PR #29 by preventing the loading of Bootstrap assets on admin pages. But although most admin pages do not need need Bootstrap, we do want it loaded when previewing a Views Bootstap view.

daggerhart commented 5 years ago

Submitted a PR that forces assets to be loaded when previewing a view that uses a views_bootstrap style plugin. This approach is very much automatic and can't be disabled. If you would prefer an approach that is configurable as another module setting, that would be fairly easy to do.

Thoughts & feedback welcome as always.