search

backdrop-contrib / views_bootstrap

This module provides a set of styles for the Views module. It allows you to create responsive Bootstrap 3.x components, such as grids, carousels, tabs, and tables, all within the configuration settings of the powerful Views module.
https://backdropcms.org/project/views_bootstrap
GNU General Public License v2.0
0 stars 7 forks source link

Force the inclusion of bootstrap assets when previewing a view in the admin interface #34

Closed daggerhart closed 5 years ago

daggerhart commented 5 years ago

This is an approach to ensuring that bootstrap assets are loaded when previewing a view that uses the style plugins provided by this module.

Attempt to address #33 concerns.

daggerhart commented 5 years ago

Also addresses #31

stpaultim commented 5 years ago

This is great and seems to address the problem I identified.

I hate to nitpick, but the PR makes sure that bootstrap is loaded on the preview page, even when "Include Bootstrap CSS & JS when used by Views" IS NOT checked and the user is NOT using a Bootstrap theme.

This means that bootstrap is working in the views preview, even when it is not working for regular users. This is only a problem, if the developer has not configured the module properly. But, I'm afraid that could be confusing to developers.

Is there a way to notify/remind users of the importance of checking the "Include Bootstrap CSS & JS when used by Views" box if their view is not working?

daggerhart commented 5 years ago

Good points. I've adjusted the PR to a new approach. This is more simple and allows for the bootstrap assets to be loaded when previewing a view.

As for warning the user that they need to check the setting, I'm not sure the best approach to that. Any ideas?

At some point users will need to visit the configuration page and read the field description. I think adding the "configure" link would help with this a good bit.