Closed bugfolder closed 3 years ago
To assist in testing, I've created a View that contains examples of all of the different Bootstrap Views, making use of the Post content type that comes with a default Backdrop installation.
To test, create several nodes of type Post, including an image (images are used in the Carousel), then install this View, either by dropping it into your active config directory or putting it into staging and then syncing.
views.view.views_bootstrap_test_135.json.txt
You will see all the URLs of the test views on the Views admin page.
Fixes https://github.com/backdrop-contrib/views_bootstrap/issues/54.
Also addresses https://github.com/backdrop-contrib/views_bootstrap/issues/20.
This is pretty much a complete rewrite of the module, starting from the Drupal 7.x-3.5 version as the base, converting it to Backdrop, then merging in the Backdrop-specific additions that have been made up to the 1.x-1.2.3 version.
I'm submitting the PR against the 1.x-1.x branch so that it can be examined and tested, but for version consistency, I would suggest turning this into a new 1.x-3.x branch, and then this version of the module would be 1.x-3.5, so that its version number matches that of the Drupal version. And then if there are any more Drupal 7 releases, we would follow the Drupal version numbering.
I have tested all of the components under these scenarios:
Of course there are many, many combinations of settings to potentially test and I haven't reached all corners of parameter-space. Further testing is solicited.
A brief summary of changes:
hook_update_N()
hooks to upgrade from either 7.x-3.5 or 1.x-1.x versions.system_settings_form()
.Release notes for this version should include a warning that templates have changed since version 1.x-1.2.3, so that if users have overridden any templates they'll need to update them. (See similar warnings in the D7 version release notes.)