search

backdrop-contrib / views_json

A Views handler that returns data as JSON objects.
https://backdropcms.org/project/views_json
GNU General Public License v2.0
1 stars 1 forks source link

Revisit grouping handling #4

Closed indigoxela closed 3 years ago

indigoxela commented 3 years ago

Grouping does some odd stuff. Some of it might even be a bug, but that needs evaluation.

And there are Notices and Warnings if the "Top-level child object" is empty when grouping, although that label isn't used when grouping.

And it's a bit unclear, whether the rewriting of field values is ignored by intention, when grouping by that field - it is not ignored with field display.

indigoxela commented 3 years ago

RE Related D7 issue: https://www.drupal.org/project/views_datasource/issues/2955990

Without further changes this might end up in invalid json, better ignore that patch for now.

indigoxela commented 3 years ago

It turned out that the rewriting of field values worked correctly, so only the handling of grouping needs to get fixed.