backdrop-contrib / views_send

Provides mass mailing using Views, enabling a list of email addresses to be produced with a view and an email to the group to be composed and sent.
https://backdropcms.org/project/views_send
GNU General Public License v2.0
1 stars 0 forks source link

Mishandling of tokens for custom text #5

Closed Graham-72 closed 8 years ago

Graham-72 commented 8 years ago

A field can be used as a token in the 'To' field for an email, except where it is a custom text field comprising two other fields. For example, if we have separate fields for [firstname] and [surname] and then combine them as [fullname] in a custom field, we can use this custom field in the body of the email but it does not work in the to field. In the example below the two fields are [field_first_name] and [field_name] and these are joined together in [views-send:custom_text] which works correctly as a token in the body of the email but not in the 'To' field.

test views send - www oliverweb net 2016-01-14 06-36-13

Graham-72 commented 8 years ago

See also Drupal issue at https://www.drupal.org/node/1833608.

klonos commented 8 years ago

@Graham-72 oh maaan!! I thought you'd have learned by now but you keep doing it and I got sick of fixing your releases' titles. Just joking, :smiling_imp:

But FYI, I believe that the common practice is to have the release title be project name + version so that it shows nicely in the GitHub notifications. You are in the habit of using it for a description instead. I fixed it (yet again) for you:

backdrop-contrib-views_send-release_description_fixed

Graham-72 commented 8 years ago

Hi @klonos Thank you for helping me yet again. I will try to get this into my thick head!. There is so much to remember and my grey cells are dying out. :smile:

klonos commented 8 years ago

Your thick head holds a beautiful brain. Thanx for porting all these modules and for all the time you've spent to do it ...while your cells were dying :smile:

Graham-72 commented 8 years ago

while your cells were dying

Thanks to our wonderful National Health Service my cells are no longer dying at an abnormal rate, except for effort of trying to understand other people's undocumented code - but maybe that is keeping them going? I enjoy working in the Backdrop team very much and am pleased to be a small part of such an excellent and progressive effort. Brilliant! Well done with 1.3.0!

Graham-72 commented 8 years ago

I believe that the common practice is to have the release title be project name + version so that it shows nicely in the GitHub notifications

@klonos thinking about this helpful advice from you, I don't think that GitHub sends me a copy of the notifications it sends out about my projects, or does it? I do see notifications for other people's work and I think 'how do they do that? Maybe they have some special software development environment?' Then I put that question to one side as one of life's many mysteries.

Graham-72 commented 8 years ago

@klonos I have found this piece of information on GitHub which may be the answer I am looking for. It tells me how to set things so that I get the notifiations. https://help.github.com/articles/receiving-email-notifications-for-pushes-to-a-repository/