search

backdrop-contrib / zeever

Theme (in development) for a digital agency website
GNU General Public License v2.0
0 stars 0 forks source link

Testimonials #19

Open stpaultim opened 5 months ago

stpaultim commented 5 months ago

This is what it looks like on the original theme: image

For now, I'm just using the existing Testimonial recipe, which isn't quite what we need for this. But, maybe we make the current recipe work or at least add more sample content. Maybe, we should improve the original recipes with more sample content.

image

stpaultim commented 5 months ago

Today we updated the Testimonials recipe to use some better profile pics.

Also, we currently have Testimonials Page in the menu. This is not part of the original Zeever site and I don't think it's necessary. We list testimonials on front page and may add the block to some other pages, but there is no need for a page of its own.

image

stpaultim commented 4 months ago

This link has been removed from the menu. I think we can close this for now.

izmeez commented 3 months ago

I agree that the testimonials may be improved by reducing the size of images, i.e. reducing the focus on who, and increasing the presence, size, prominence of what is being said.

stpaultim commented 3 months ago

@izmeez - Today I realized that I had already reduced the size of the testimonial images. But, my change was broken due to a syntax error in the css file.

I've fixed that and am releasing the update in a few minutes. If you have other specific suggestions, feel free to post them here.

This is a good example of why I am using a single issue queue. If one is testing the Zeever theme with the Digital Agency package, how would one know where to put this issue. This could be an issue for the Testimonial Recipe, it could be an issue for the Digital Agency Recipe Package, or it could be someething that is left to be fixed by the contributed theme Zeever.

In fact, I have decided to address this issue in the Digital Agency Recipe, but I don't think that anyone else could have necessarily predicted this unless they are folling the project pretty closely.

I'll reopen this issue for now, in case anyone has additional feedback on this feature.

stpaultim commented 3 months ago

@izmeez and others. This is the change. Should I do more? Keeping in mind that individual contrib themes can do more than this.

BEFORE:

image

AFTER:

image

izmeez commented 3 months ago

How about putting the text first maybe even with large leading graphic quote symbol, then have the image down with the name?

stpaultim commented 3 months ago

@izmeez

Kinda like this?

image

:-)

If I have time before the 1st, I'll take a stab at this. I like it, it just feels like a bit more work and I'm lazy.

The good news is that it will require (encourage) me to figure out how to use the new SVG icon API.

izmeez commented 3 months ago

Yes, much better. Although I'd suggest the quote be on the left of the actual text and be the correct opening bracket 66 to avoid it looking like a 99 centered all by itself. And maybe increase the text font size for a bit more prominence.

stpaultim commented 3 months ago

image

@izmeez - After a lot of beating head against wall with icon api, I got this.

stpaultim commented 3 months ago

image

izmeez commented 3 months ago

@stpaultim I like it. I would suggest using the opening quote: unicode U+201C | LEFT DOUBLE QUOTATION MARK

Do you want to add the sub-heading: "Feedback from our clients"?

izmeez commented 3 months ago

@stpaultim I did not realize you were trying to do this with an svg icon until I saw all the activity in the zulip chat and I see the phosphor svg icons in backdrop only have one icon for quotes, not a pair. I thought you were just going to do it with css, like https://stackoverflow.com/questions/32909991/adding-quotes-to-blockquote

stpaultim commented 3 months ago

@izmeez - I liked the idea of using this as an opporunity to try using the new Icon API in Backdrop. As you can see, it was my first time using it.

izmeez commented 3 months ago

There are some internet repos of svg quote icons that include both open quote and close quote icons:

https://www.flaticon.com/free-icons/quotes https://www.svgrepo.com/vectors/Quote/ https://iconscout.com/icons/open-quote

and more ...

stpaultim commented 2 months ago

I took the advice from @laryn and simply used css to invert the single icon for dual purpose use.

Digital Agency Recipe Package

image

Zeever Theme

image

Do you want to add the sub-heading: "Feedback from our clients"?

I'm thinking I will leave the generic title in the actual "Testimonials" recipe. BUT, I can modify it to be a bit more opinionated in the Digital Agency Recipe Package.

izmeez commented 2 months ago

@stpaultim This is not quite right, the image appears to be mirrored not rotated. It should look like 66 and 99. Also, it might look better if the icons are filled rather than open.

stpaultim commented 2 months ago

@izmeez - I've seen the quotes done both ways.

(1) Rotated (2) Flipped

image

After looking around a bit, it does seem like rotating them as you suggested is more common. So, I'll go with that (coming soon).

My goal in the recipe package is make everything look good enough that it can be used out of the box, not to make a final polished theme. I'm assuming that for most sites, there will be a theme involved as well.

I'd like to sticke with the quotes that are provided by Backdrop Core for the recipe. Each theme has the possibility to replace them with whatever quotes they want to use. Maybe we can demonstrate that in Zeever, but replacing them in Zeever with solid quotes.