backdrop-ops / backdrop-pantheon

Version of Backdrop CMS that runs on the Pantheon hosting platform.
GNU General Public License v2.0
5 stars 8 forks source link

Bump MariaDB Version to 10.4 #68

Closed quicksketch closed 1 year ago

quicksketch commented 1 year ago

There's a long-threaded issue about a Pantheon-specific upgrade problem when moving from D7 to Backdrop at https://github.com/backdrop/backdrop-issues/issues/5496. It seems to be fundamentally caused by MariaDB on Pantheon being out of date. Using the Backdrop upstream currently defaults to MariaDB 10.0.23, which was released Dec 18, 2015. This 8 year old version of MariaDB seems to not support upgrading from Drupal 7 or UTF8-MB4 support (emoji support). We should bump the version to at least MariaDB 10.3.

https://pantheon.io/docs/pantheon-yml#specify-a-version-of-mariadb

klonos commented 1 year ago

PR to bump it to 10.4 (which happens to be what the Drupal upstream is using as well): https://github.com/backdrop-ops/backdrop-pantheon/pull/70

laryn commented 1 year ago

Looks good to me!

klonos commented 1 year ago

@laryn @quicksketch can someone please merge this then?

jenlampton commented 1 year ago

I'm going to update the mysql version via pantheon.yml for one or two of my Backdrop sites and see what happens. 🤞

jenlampton commented 1 year ago

Well, I updated my pantheon.yml, but it didn't seem to do anything?

# MySQL / MariaDB Version:
# https://docs.pantheon.io/pantheon-yml#specify-a-version-of-mariadb
database:
  version: 10.4

The comnand line said to check the workflows via the dashboard:

Screen Shot 2023-02-16 at 1 41 13 PM

The workflows said it was done:

Screen Shot 2023-02-16 at 1 40 13 PM

But the status report still reports version 5.5.30

Screen Shot 2023-02-16 at 1 40 36 PM

I confirmed and my live site also still reports: MySQL, MariaDB, or equivalent version 5.5.30 ... So no change.

I'll open a ticket with them to see if this is what's supposed to happen, or of maybe I did something wrong.

jenlampton commented 1 year ago

Pantheon is reporting that the database version has been updated, but that the status report isn't able to tell. We are using the following to get the version information:

Database::getConnection()->version()

This is somehow returning the wrong information.

my understanding is that D9 uses SELECT VERSION() but lower than that relies on PDO which goes through a sqlproxy that always reports back 5.x

Here's the relevant issue for Drupal 8 https://www.drupal.org/project/upgrade_status/issues/3213533

I'm going to open a matching backdrop core issue to fix the status report. (edit: I found an existing one, please see https://github.com/backdrop/backdrop-issues/issues/5447)

So far - my site is operating just fine o 10.4 (other than not being able to report the version). I'm going to push this change live 🤞

klonos commented 1 year ago

Pinging @laryn and @herbdool ...can we please merge this and make sure that this version is what's being used in new Backdrop installation on Pantheon?

laryn commented 1 year ago

Thanks @klonos, @quicksketch, and @jenlampton -- merged!