search

backdrop-ops / backdropcms.org

Issue tracker for the BackdropCMS.org website
https://backdropcms.org
25 stars 19 forks source link

Project Browser Server on projects.b.org returns 10 results if text search is used #1014

Closed yorkshire-pudding closed 10 months ago

yorkshire-pudding commented 10 months ago

See https://backdrop.zulipchat.com/#narrow/stream/218635-Backdrop/topic/Search.20for.20new.20module

Steps to reproduce

  1. In a Backdrop instance navigate to admin/modules/install
  2. Search for a term that is likely to return more than 10 results (e.g. "image" or "menu")
  3. Check the results

Expected results All relevant results according to specification - I think it searches on title and description

Actual results A maximum of 10 results is shows

@docwilmot believes it is this line: https://github.com/backdrop-ops/backdropcms.org/blob/86fcb933471f899af0bb9491c08859c59e74206a/www/modules/custom/borg_pbs/borg_pbs.module#L84

And that the line doesn't need to be there.

yorkshire-pudding commented 10 months ago

I've created a PR that implements @docwilmot 's suggestion. Please review/test and merge if appropriate.

jenlampton commented 10 months ago

I have tested the PR locally and get 20 items per page, with a pager for both "image" and "menu".

jenlampton commented 10 months ago

Merged, and deployed.