backdrop-ops / backdropcms.org

Issue tracker for the BackdropCMS.org website
https://backdropcms.org
25 stars 21 forks source link

Fix projects showing wrong recommended release and showing deleted releases #468

Open herbdool opened 6 years ago

herbdool commented 6 years ago

As per the release tagging recommendation https://api.backdropcms.org/converting-modules-from-drupal:

When tagging your Backdrop module for release, please use the same version number as the Drupal module being ported. For example, if you are porting the 7.x-4.15 version of webform module, that should become the 1.x-4.15.0 version of the Backdrop module. Any bug fixes would increment the last number to 4.15.1 or 4.15.2.

I started changing the numbering of projects I help maintain. But on the project page the new releases are not being marked as recommended. Rather they stick with the old 1.x-1.* releases. I think this is how it works as expected like on d.o but on b.org maintainers don't have access to edit the project nor release nodes.

The messed up projects:

1) I need the latest 4.x or 3.x to be marked as recommended. 2) I need release nodes deleted where the github release has been deleted.

@jenlampton @serundeputy

herbdool commented 6 years ago

@serundeputy has helped by manually switching the major version to the higher versions as requested so 1. is dealt with at least for these projects. For the record, this is done here /node/*/edit/releases. Only a handful of people have permission to do this, so maintainers will need to ask here or on gitter.

The second issue still needs to be resolved where there are some deleted releases that need the associated nodes deleted. And we also need to write up some documentation for maintainers so they know how to get this done.

The deleted releases:

indigoxela commented 2 years ago

Possibly I just ran into the same problem re the recommended release. @herbdool do you agree?

recommended-release

https://backdropcms.org/project/snazzy

@bugfolder already verified that it's not a caching problem.

Version 1.x-1.1.1 still shows as recommended, although 1.x-2.0.0 came out today.

bugfolder commented 2 years ago

Per @herbdool's https://github.com/backdrop-ops/backdropcms.org/issues/468#issuecomment-412380509 above, to fix the immediate issue, I've set the recommended major release to "2" for Snazzy, which is now showing the proper recommended download: https://backdropcms.org/project/snazzy.

It seems like the proper default behavior would be that when a new release is made, check the major version, and if it is different from[Edit: higher than] the current recommended major version, bump up the recommended major version. Any potential problems created by making that change?

bugfolder commented 2 years ago

I deleted the three mailsystem release nodes mentioned above.

I didn't delete https://backdropcms.org/project/releases/webform_civicrm-1x-1210 because it still has a valid release tag at https://github.com/backdrop-contrib/webform_civicrm/releases/tag/1.x-1.21.0.

Edit: I see that it was created in error, though, on GH (should have been 1.x-4.21.0, which also exists) so I will go ahead and delete the node.

bugfolder commented 2 years ago

I have added substantially to the "Creating Releases" (first) section of https://docs.backdropcms.org/documentation/maintaining-your-project, including instructions on contacting admins in Zulip to change the recommended branch (or for other reasons). Further suggested changes are welcome.