Open docwilmot opened 3 years ago
How does it look if you just add the shadow, leaving out the border? Are they still indistinct?
Also better. Also think the part of the card with the description could be differentiated from the screenshot as well.
Friendly reminder: that page is broken for several months now:
https://backdropcms.org/showcase
A suggestion for getting the two-column style back:
.view-showcase .view-content {
display: grid;
grid-template-columns: repeat(auto-fill, minmax(360px, 1fr));
gap: 3rem;
}
Not really pretty, but at least less ugly. :wink:
And some box-shadow for individual items:
.view-showcase .views-row {
background: #fff;
box-shadow: 0 0 12px #0003;
}
Friendly reminder: that page is broken for several months now
Oh yes, the Showcases view is really a shame. Who can implement suggestions?
Why NOT use Backdrop CMS? - answered that page. :-(
I can't implement it, but suggest. :wink: Another one, more masonry-style, as not all items are forced to same height:
.view-showcase .views-row {
background: #ffffff;
box-shadow: 0 0 15px #00000033;
margin-bottom: 4rem;
break-inside: avoid;
}
@media (min-width: 48em) {
.view-showcase .view-content {
column-count: 2;
column-gap: 4rem;
}
}
Changes to the view aren't necessary, but please adapt the showcase_preview image style to not be smaller than the views-row, because that makes the images so blurry. Currently it's 512x512, but even if we use columns like suggested, they still should be at least 546px wide.
The Showcase page layout/styling has already been fixed: https://github.com/backdrop-contrib/borg/issues/28 We're just waiting on a new release of the Borg theme to install on B.org (ping @jenlampton).
Here's what the page will look like once the theme's updated to the latest version:
I've applied the patch, committed the fix, and pushed up to backdropcms.org: https://backdropcms.org/showcase
Was this meant to have fixed the indistinctness? I dont see significant difference?
Looking at the commit, the answer is no; it fixed the broken columns but didnt actually deal with this issue's complaint.
I was wondering the same thing. This issue got sidetracked and should really be about styling the Showcase items to stand out better.
Ah, sorry folks. I thought that fix was what was wanted here. Jumped the gun on closing the issue -- thanks for catching it @docwilmot and @BWPanda.
Another remaining task: update the image style to match the column width - to prevent the blurry look. Do we have an issue for that already?
@indigoxela When I look at the page, the images used are 512px wide, and the columns they're now in are 548px wide... Is that really enough of a difference to worry about?
Is that really enough of a difference to worry about?
It may depend on the person looking at it. :wink: For me this looks like "blurry bullshit", but maybe I'm a little picky re visual glitches.
The pictures look a bit blurry to me at well. (And being so small, they look very blurry on displays of higher pixel density.)
The cards just blur into each other and the background to my eyes.
Added a black border and black shadow for dramatic effect; they seem more like cards then:![screenshot-backdropcms-org-showcase-1612544232125](https://user-images.githubusercontent.com/1042283/107064755-e855c080-67a9-11eb-8c57-89f9682326e9.png)