Closed alexfinnarn closed 3 years ago
Yes, this is a great idea. thanks! Would you like to make a PR against the readme and squish it in somewhere?
Okay. I added basically what I had written above. Feel free to change or add more Dad jokes :)
Thanks @alexfinnarn ! I've added two small comments to the PR. One other thought, since I want the 'Backdrop Contributed Project Agreement' to be high on the page, can we move this new section below it, or maybe even below 'Additional notes for non-coders' ? Otherwise it's looking good!!!
Cool. I think I've made all the changes listed in the PR.
@alexfinnarn the new PR introduces numerous instances of multiple spaces and I think breaks the 80 character limit per row.
sorry, I was trying to edit via Github UI which obscures such things. PR updated.
@alexfinnarn what I tend to do is copy the text to a text editor that has a marker for the 80 characters limit (you can also consider one that has spell checking), I edit the text there, and when I'm ready, I copy/paste it back on GitHub 😉
I approved the changes and also made a recommendation of how the paragraph about subscribing to the d.org issue queue should be better worded. Please review and let me know what you think about it. Thanx.
I'm in the process of transferring a module to backdrop-contrib, and Github's asking me about team access:
Please select any teams you wish to have access to backdrop-contrib/featherlight.
I'll try to work out what to do here, but might be good to add this to the proposed steps...
That's a great point @BWPanda, please let us know if you need help figuring out what to do! Once we know I would love to get it added to the documentation :)
I just ticked both options ('authors' and 'security' IIRC). Still trying to figure out how to change from 'master' branch to '1.x-1.x' and then make a release...
@BWPanda I've added a more detailed answer over at https://github.com/backdrop-ops/contrib/issues/234. Would you be willing to create a new PR for this repo with the steps you followed?
This is what we recommend for permissions when transferring a project into the contrib group: Team: Authors - Admin access Team: Security - Write access Yourself, with Admin access (just in case!)
Re-opening since we need more updates :)
@jenlampton I never saw an option to add myself as an admin... And I can't create a screenshot without transferring another repository over.
It's a blank "Collaborators" text field at the very bottom of the page, but when you type into it it autocompletes. Not very intuitive... Maybe this would make a good video? I'll give that a shot :)
Here's what I see when I transfer a repository:
No option to select myself as an admin...
Please now delete that repo: https://github.com/backdrop-contrib/dummy
No option to select myself as an admin...
It's not in this section, as this is for "Teams". The "Collaborators" section should be immediately below.
One thing to note is that you are a member of the "Authors" team so by transferring a project from yourself to Authors you are not necessarily removing your own access - as long as you grant Authors "Admin" privileges when you transfer.
After you check those two boxes, does it let you choose read/write/admin?
Please now delete that repo: https://github.com/backdrop-contrib/dummy
deleted :) wanna try it again?
Here is the entire process that I see. Hope this helps explain things...
Can delete this again, thanks: https://github.com/backdrop-contrib/dummy2
Sigh, yes, this is a problem :(
We have a bot that @Gormartsen has been working on that is supposed to "fix" the permissions on transferred repositories after the fact, but AFAIK that hasn't been set up yet.
Until that starts working feel free to open an issue in this queue for any project you need to have fixed. (And maybe we should add that to our new-maintainer notes as well, until we get the bot going.)
Ok, good to know what the issue is. I'll make a PR with updated instructions then.
Ok, good to know what the issue is.
I'm not sure we've sorted out the issue yet, but we do at least know it's a problem and are planning on fixing it using the GitHub API, since apparently the UI can't handle it. :(
I did make one change to the group settings after watching this video, but I can't test it since I'm the organization owner... hm. Maybe I can test it as the GitHub bot? ...
If you need me to try transferring again to test anything, let me know.
ooh! that worked for dragonbot! Can you try it again?
That worked! Same as last time (see above video), but this time the Settings option was available once I visited the transferred repo. I was listed as an admin, however Authors and Security only had Read access (had to manually change to Admin and Write respectively).
Well, one step in the right direction :) I'm not sure how to set the intial access level for the teams... I looked all over and couldn't find anything. Maybe we'll need the bot for that.
Looks like these still need deleting: https://github.com/backdrop-contrib/dummy3 https://github.com/backdrop-contrib/egg
deleted, thanks! :)
Any thoughts on my PR above?
Merged!
I know this info was put into the issue where I applied, but I'm not seeing it here in the readme and don't know where one would find such information. Something like...
After You Join: