search

backdrop-ops / contrib

Apply to join the contributed code developer team.
23 stars 16 forks source link

Port request for NG Lightbox #449

Open djzwerg opened 4 years ago

djzwerg commented 4 years ago

Name of the module, theme, or layout NG Lightbox

Link to the drupal.org module, theme, or layout https://www.drupal.org/project/ng_lightbox

(Optional) Link to an issue in the drupal.org queue asking the Drupal community if anyone is working on a Backdrop port of this project https://www.drupal.org/project/ng_lightbox/issues/3177470

djzwerg commented 4 years ago

I've tried to port it myself but it doesn't work: https://github.com/djzwerg/ng_lightbox :-(

docwilmot commented 4 years ago

Your JS file still has "Drupal" strings. Thats a start.

djzwerg commented 4 years ago

Thanks @docwilmot! Now I've replaced them by "Backdrop" but it still doesn't works.

Any hints are welcome.

oadaeh commented 4 years ago

@djzwerg, did you make the port code changes manually, or did you use https://github.com/backdrop-contrib/coder_upgrade to make them? If the former, you might try the latter.

I see in your .info file this that does not belong there: function hook_autoload_info() { return array( 'ClassName' => 'tests/ng_lightbox.test', ); } Though that probably isn't keeping it from working.

docwilmot commented 4 years ago

I think its working with minor changes https://github.com/djzwerg/ng_lightbox/issues/1