Contrib Group Application: gto1 + several modules

[gto1]

Hello and welcome to the contrib application process! We're happy to have you :)

Please indicate how you intend to help the Backdrop community by joining this group

• Option 1: I would like to contribute a project

Based on your selection above, please provide the following information:

The name of your modules:

Image Class Webform Scheduler Views Merge Rows Views Field Formatter

Please note these 3 requirements for new contrib projects:

• [x] Include a README.md file containing license and maintainer information. You can use this example: https://raw.githubusercontent.com/backdrop-ops/contrib/master/examples/README.md
• [x] Include a LICENSE.txt file. You can use this example: https://raw.githubusercontent.com/backdrop-ops/contrib/master/examples/LICENSE.txt.
• [x] If porting a Drupal 7 project, Maintain the Git history from Drupal.

Post a link here to an issue in the drupal.org queue notifying the Drupal 7 maintainers that you are working on a Backdrop port of their project

I still need to do this.

If you have already contributed code to Backdrop core or contrib projects, please provide 1-3 links to pull requests or commits The completed/ported modules are in a private Gitlab repo at this time.

If you have chosen option 2 or 1 above, do you agree to the Backdrop Contributed Project Agreement YES

[jenlampton]

Hi @gto1, and welcome to Backdrop contrib! We're thrilled to have you, and looking forward to your contributions.

In order to verify the 3 requirements for a new contrib project, we'll need to see any one of your 4 modules in a public GitHub repository (but not all of them!). Could you copy one of them over for our review?

Below is how I do it for my existing projects:

1. Go to https://github.com/new in your browser, and create a new repository with the same name, for example: image_class
2. Copy the clone URL, for example: git@github.com:gto1/image_class.git
3. Navigate into the Git root for the existing project
4. Add a second remote, for example: git add remote upstream git@github.com:gto1/image_class.git
5. Push the current code up to the new remote, for example: git push upstream
6. Then paste the URL for the project here, for example: https://github.com/gto1/image_class

[gto1]

Thanks Jen! Excellent, I'll share one of the modules first thing tomorrow.

Message ID: @.***>

[gto1]

https://github.com/gto1/image_class/tree/1.x-1.x

[gto1]

https://github.com/gto1/views_field_formatter https://github.com/gto1/views_merge_rows https://github.com/gto1/webform_scheduler

[jenlampton]

Please note these 3 requirements for new contrib projects:

• [x] Include a README.md file containing license and maintainer information. You can use this example: https://raw.githubusercontent.com/backdrop-ops/contrib/master/examples/README.md
• [x] Include a LICENSE.txt file. You can use this example: https://raw.githubusercontent.com/backdrop-ops/contrib/master/examples/LICENSE.txt.
• [x] If porting a Drupal 7 project, Maintain the Git history from Drupal.

Thanks @gto1! The image_class project meets all the requirements for joining contrib, so an invite is on the way :)

Feel free to transfer the repository into the backdrop-contrib group at any time (you can ask here if you have questions).

[jenlampton]

I also did a quick code review, and everything looks really good!

I have only very minor notes -- Items in this comment are only suggestions, take or leave them as you please. We do this review specifically looking for things that may be done differently between Backdrop and Drupal in the hopes that this information might help with the transition for those new to Backdrop :)

README.md notes

• For the section on Issues, it would be helpful if "the issue queue" was linked to the specific GitHub queue for this module (I assume you are already planning to do this once the link to the queue is confirmed, but still noting it here just in case)
• Please use a URL to a GitHub profile for all current maintainers.
• If possible, please link the names directly in the Credits section, rather than printing the complete URL. For example: Ported to Backdrop CMS by Greg OToole https://github.com/gto1 would become Ported to Backdrop CMS by [Greg OToole](https://github.com/gto1)

.info file notes

• In views_merge_rows.info there are quotation marks around the package that aren't necessary (but also aren't problematic)
• Several modules list Views as a dependency dependencies[] = views. This is not strictly necessary anymore, because Views is not a module that can be disabled in Backdrop. The Views module is both required and hidden, because it runs nearly all of our administration listings. (but even so, I usually leave this line in my views modules too!)

Location of files in the module

• Files that contain PHP classes should be placed into an /includes/ subdirectory. This makes it easier for developers to scan the list of files and directories in a module and immediately know the module contains classes, without even needing to open any files. In the case ofviews_merge_rows_plugin_display_extender.inc it would be the only file in the directory, but we do still recommend placing it there for consistency across modules.

General coding notes

• Blank lines after the opening <?php tag could be removed (if you want). The extra line breaks were required in Drupal because of the previous CVS version control system, but are not needed anymore.
• For new functions, @params and @return should appear in the docblock. (This is not necessary for hook implementations.)

Module specific notes

• There's a function definition for boolval() in views_field_formatter.module that's docblock indicates that it is for PHP versions less than 5.5 - but the minimum required version for Backdrop CMS is PHP 5.6 -- so this can safely be removed.

[gto1]

Hi @jenlampton Thanks. Is anything else needed from me here (other than these optional suggestions)? Not sure what the next steps are. I can certainly do some of these clean-up suggestions here.

[jenlampton]

@gto1 nothing else is needed, you are now a valued member of the contrib group!

edit: There was a previous step I forgot -- check your email and click on the link from GitHub to accept the invitation to join the group!

The only next step is to transfer the repository there. You can ask here if you have questions while doing so, and when you are done, we can close this issue 🎉

[gto1]

Thanks @jenlampton I'm working on transferring the repos and got this message.

[jenlampton]

@gto1 It looks like the invitation we sent you had expired. I have retried it. Please check your inbox for a message from GitHub, and follow the instructions to join the group. Once you are a member you will be able to transfer the repository.

[gto1]

Great, thanks, just accepted the new invite.

[jenlampton]

I'm going to mark this issue as resolved, but if you have any questions @gto1 feel free to still ask here or open a new issue.