search

backdrop-ops / contrib

Apply to join the contributed code developer team.
23 stars 16 forks source link

Join the Backdrop contributor community? #798

Open nico8948 opened 4 months ago

nico8948 commented 4 months ago

Can i join the Backdrop contributor community?

laryn commented 4 months ago

@nico8948 Of course, and we'd love to have you! The README linked below contains further information about the process to officially join:

https://github.com/backdrop-ops/contrib/blob/main/README.md

stpaultim commented 4 months ago

@nico8948 Any questions we can help you with?

nico8948 commented 4 months ago

i've forked https://github.com/backdrop-contrib/printmpdf, updated it do the latest php version en mpdf. i've made a merge request. No answer?

Maybe the wrong git site? https://gitlab.com/ulterius/salestracker-crm It is a Sales backdrop module, is this interesting for Backdrop?

yorkshire-pudding commented 4 months ago

Maybe the wrong git site? https://gitlab.com/ulterius/salestracker-crm It is a Sales backdrop module, is this interesting for Backdrop?

Just a comment on your use of Bee @nico8948 . That is quite a dated fork, so by maintaining a copy you are setting yourself up for a lot of updates and support requests. I note you've added the node command, which I stated wasn't suitable for bee but you don't need to fork bee to have that command available. Bee looks for other commands in three different places:

This hook can be invoked to provide additional commands to Bee. It should reside in a bee command file (HOOK.bee.inc) which should be placed in a custom/contrib module, in the .bee folder in the user's HOME directory or in the .bee folder in the parent folder of the Backdrop root directory.

If you're using an install script, you could use this to copy a file to one of the two latter locations for node.bee.inc and any specific bee commands for the module itself would live in the module folders.

Likewise, as you've done with modules, you can also use the script to download and install bee direct rather than keeping it in your module folder.

is this interesting for Backdrop?

Probably, but it might be good to see if there is a way this can be installed on existing sites using dependencies, a hook_install() function within the module and/or a recipe without needing to use an install script.

yorkshire-pudding commented 4 months ago

i've forked https://github.com/backdrop-contrib/printmpdf, updated it do the latest php version en mpdf. i've made a merge request. No answer?

@nico8948 - you haven't added Fixes #5 to the top of the pull request description; that would link the PR to the issue. Secondly, the issue is not very clear that you are updating the library and making it compatible with PHP 8.2 so it would be hard for anyone to realise that you wanted to merge it from the issue.

Once you've done the above, and tagged the maintainer (see the README) in the issue and waited 2 weeks, you can then call on the Bug squad by tagging @backdrop-contrib/bug-squad in the issue.