backdrop-ops / contrib

Apply to join the contributed code developer team.
23 stars 16 forks source link

Contrib Group Application: Layout Body Class #822

Open catorghans opened 1 week ago

catorghans commented 1 week ago

Hi,

I created a simple module which does something I wanted to have since my first backdrop project: Layout Body Class, it simply adds the name of the active layout to the body classes. https://github.com/catorghans/layout_body_class

Probably can be solved in other ways too, but this is easy to understand for anyone who needs something like this.

It has a Readme and a Licence file. So have a look.


Please indicate how you intend to help the Backdrop community by joining this group

(option 1) The name of your module, theme, or layout Layout Body Class

(option 1) Please note these 3 requirements for new contrib projects:

If you have chosen option 2 or 1 above, do you agree to the Backdrop Contributed Project Agreement

jenlampton commented 10 hours ago

Hi @catorghans and welcome to backdrop contrib!

I have verified this project meets the requirements :)

In order to send you an invite, we need you to agree to the Backdrop Contributed Project Agreement

Can you please reply YES or NO?

jenlampton commented 10 hours ago

I have also reviewed the code in your project, and everything looks great!

I have two small recommendations (that you can choose to ignore if you like)

1) The blank line (line 2) in layout_body_class.module can be removed (this was necessary in Drupal back when it used the CVS version control system, and became start of the standard -- not needed here anymore) 2) There should be a blank line as the last line (line 16) in layout_body_class.module (This is recommended for Git projects, to prevent unnecessary diffs)