search

backdrop-ops / docs.backdropcms.org

Website for displaying Backdrop CMS documentation and API source code.
https://docs.backdropcms.org/
6 stars 6 forks source link

Update the Form API documentation with the newly-introduced `#required_message` property #209

Closed klonos closed 1 year ago

klonos commented 2 years ago

These were introduced with https://github.com/backdrop/backdrop-issues/issues/5348 (in Backdrop v1.23.0).

bugfolder commented 2 years ago

Should we introduce these now, noting that they are introduced with Backdrop v1.23.0, or wait until 1.23.0 is actually out?

bugfolder commented 2 years ago

If we add the line "Introduced in Backdrop 1.23", we could go ahead and add these.

@klonos, @quicksketch, but looking at the code in the newly merged 1.x, I don't see any reference to #required_value_missing, and looking at the patch file, it looks like it was added and then removed. Was that an oversight?

quicksketch commented 2 years ago

Yeah in the end #required_value_missing was removed, see my comment (and @docwilmot's right before mine) at https://github.com/backdrop/backdrop-issues/issues/5348#issuecomment-1114051634

So there's only one new property to document.

bugfolder commented 2 years ago

#required_message is added to properties.

It will take a little while to get it connected to all the form elements (lots of individual node edits), so leaving this issue open for now.

herbdool commented 1 year ago

@bugfolder this seems to me like it is done?

bugfolder commented 1 year ago

There's still a fair amount to do, per this:

https://docs.backdropcms.org/admin/reports/fapi-check

But I think it needs some refining/checking; there's probably some false positives in there.

bugfolder commented 1 year ago

The refining could (should?) perhaps be moved to a follow-up issue.

bugfolder commented 1 year ago

https://docs.backdropcms.org/form_api#required_message is now connected to the various form elements, so closing this issue.