search

backdrop-ops / forum.backdropcms.org

The Forum for BackdropCMS.org.
https://forum.backdropcms.org/
4 stars 10 forks source link

Set search block title/label as a placeholder instead #101

Open ghost opened 5 years ago

ghost commented 5 years ago

This is a follow-up to https://github.com/backdrop-ops/forum.backdropcms.org/issues/90

The search block has the following title/label: "Search all forum topics". I think this'd look better as placeholder text in the field instead:

Before: Before search placeholder

After: After search placeholder

It seems we might need to also reduce the font size...

ghost commented 5 years ago

Reduced font size (but I think this affects typed/entered text as well, not just the placeholder):

Reduced search placeholder size

stpaultim commented 5 years ago

The previous iteration used placeholder text. I suppose @jenlampton had an opinion about this when she reverted to using a label instead of placeholder text.

I don't feel strongly about this. Other than, I think that the overall design is a bit too airy and could be more compact. Using placeholder text instead of a label would take up less real estate.

I will comment more later on the overall airiness of the design/theme.

:-)

Just something to look forward to....

jenlampton commented 5 years ago

I don't think I touched anything but the home page, I didn't mean to anyway. I checked the other pages and it looked like they had both a hidden label and placeholder text, which was what we had discussed :)

If other changes are requested, we can revisit!

On Tue, Nov 19, 2019, 5:49 PM Tim Erickson notifications@github.com wrote:

The previous iteration used placeholder text. I suppose @jenlampton https://github.com/jenlampton had an opinion about this when she reverted to using a label instead of placeholder text.

I don't feel strongly about this. Other than, I think that the overall design is a bit too airy and could be more compact. Using placeholder text instead of a label would take up less real estate.

I will comment more later on the overall airiness of the design/theme.

:-)

Just something to look forward to....

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/backdrop-ops/forum.backdropcms.org/issues/101?email_source=notifications&email_token=AADBER5ZBLQECS2ZX3BKSN3QUSJS3A5CNFSM4JO7DUSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEQM5BY#issuecomment-555798151, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADBER5GRH3SG6GTRERRGBLQUSJS3ANCNFSM4JO7DUSA .

ghost commented 3 years ago

Here's a PR: https://github.com/backdrop-ops/forum.backdropcms.org/pull/115

And since Tugboat's over quota, here's a before/after screenshot of the changes:

forum_search_homepage

ghost commented 3 years ago

Tugboat PR sandbox working now.