search

backdrop-ops / forum.backdropcms.org

The Forum for BackdropCMS.org.
https://forum.backdropcms.org/
4 stars 10 forks source link

Allow users to edit their comments #87

Closed stpaultim closed 5 years ago

stpaultim commented 5 years ago

Was there an intentional decision at any point to not allow users to edit their comments?

I am unable to edit my comments (I can because I have admin privileges, but regular users can't).

I'm used to being able to edit my comments on Github and sometimes I write part of a reply to someone, save it, and then go back to edit the rest but I can't.

I think it should be acceptable to allow users to edit comments.

Maybe this was just an accident. I feel like I used to be able to edit comments. We do allow users to edit their original post/question.

klonos commented 5 years ago

I agree 👍 ...I find being able to save/edit my comments valuable.

stpaultim commented 5 years ago

We discussed this in the last UX meeting and no one could think of any conscious decision to prevent users from editing comments. It was suggested that we go ahead and turn them on, but be careful to make sure that the edit button looks ok.

@jenlampton - Authenticated users already have permission to edit their comments on forum posts. But, there is no edit button.

Is there something else going on here?

How_do_I_make_a_private_website____Backdrop_Forum

jenlampton commented 5 years ago

I remember editing comments being weird. We may have to manually add the edit link in via preprocess.

stpaultim commented 5 years ago

I need to have a conversation with you about how I can help develop for the forums. I guess, I would need a database dump if I want to work locally and create a PR. How is that handled for forums.backdropcms.org?

stpaultim commented 5 years ago

It would seem that the problem is with Backdrop Core. Apparently, we don't ever provide an edit button for comments. https://github.com/backdrop/backdrop-issues/issues/3948

jenlampton commented 5 years ago

Yeah, I remember that being super weird about Drupal since the olden days. I've seen themes that add the button, or we could add it via the comment $links in a custom module.

stpaultim commented 5 years ago

Yeah. There was a core bug that prevented the "edit" comments button from displaying. It was fixed and 1.13.3 and as of today, I can edit my comments.

https://github.com/backdrop/backdrop-issues/issues/3948