search

backdrop-ops / localize.backdropcms.org

Host translation files for Backdrop CMS.
2 stars 4 forks source link

Allow bulk-approvement of translation suggestions? #33

Open olafgrabienski opened 5 years ago

olafgrabienski commented 5 years ago

There's no way to bulk-approve translation suggestions. When there are many translation suggestions for a language (there could be hundreds and thousands), there's no feasible way to approve them all.

olafgrabienski commented 5 years ago

Recently we needed to bulk-update the suggestion status of many translations, but that wasn't a typical situation. The issue came up when the configuration of the translation server wasn't well designed, and a person submitted many translation suggestions via a language file.

Meanwhile I think it doesn't make sense to bulk-submit suggestions importing a language file. Even if there was a technical option to confirm thousands of suggestions, a translations supervisor wouldn't be able to evaluate such a great number of strings. In my opinion it makes more sense to provide the following workflows:

(1) Translation suggestions can be provided as individual strings via the interface, and will be moderated individually by a translations supervisor.

(2) Translation via the import of a language file should only be used when there's no need of moderation or confirmation. Examples:

olafgrabienski commented 5 years ago

For the time being, I've removed the Import gettext files permission from the Translation group "Member" role, to avoid another issue where we have to bulk-confirm suggestions.

On the import page there are however two "Status" options, one of them: "Store as suggestions needing approval, possibly discussion". Admin group members or Translations supervisors could use this option accidentally during an import, so maybe we should hide it.

jenlampton commented 5 years ago

For the time being, I've removed the Import gettext files permission from the Translation group "Member" role, to avoid another issue where we have to bulk-confirm suggestions.

I'd rather we have the suggestions than have nothing at all. I don't mind doing the updates for now, or building you a button to do them in bulk, as needed.

maybe we should hide it.

Good idea. I'll see if I can find that...

jenlampton commented 5 years ago

On the import page there are however two "Status" options, one of them: "Store as suggestions needing approval, possibly discussion". Admin group members or Translations supervisors could use this option accidentally during an import, so maybe we should hide i

done. see https://localize.backdropcms.org/translate/languages/ar/import

olafgrabienski commented 5 years ago

For the time being, I've removed the 'Import gettext files' permission from the Translation group "Member" role, to avoid another issue where we have to bulk-confirm suggestions.

I'd rather we have the suggestions than have nothing at all. I don't mind doing the updates for now, or building you a button to do them in bulk, as needed.

Thank you! Regarding the permission to upload multiple translation suggestions in a language file, what would be the use case? As said above, it's not possible to moderate so many suggestions.

And, if we assign the permission again, we have to test how it works now with the hidden "Store as suggestions" option. (Thanks for hiding it!)

olafgrabienski commented 5 years ago

And, if we assign the permission again, we have to test how it works now with the hidden "Store as suggestions" option.

I saw that the Import gettext files permission has been re-assigned to the "Member" role, thus I've tested the import as a group member: The translations were stored as suggestions, as expected.