search

backdrop / backdrop-issues

Issue tracker for Backdrop core.
144 stars 40 forks source link

[UX] Add the ckeditor spell-check plugin #2071

Open jenlampton opened 8 years ago

jenlampton commented 8 years ago

I got a request today to add "All the buttons" from CKEditor back into backdrop. When I followed up asking what in particular was missing, one answer I got was the Spell-Check button. I had personally thought this wasn't necessary anymore since browsers and OSes now do spell-check, but let's take a poll. Did anyone use the spell-check feature in Drupal (or in WordPress) and should we include it in Backdrop? Should it be enabled in the editor out-of-the-box?

Existing CKEditor plugins

Graham-72 commented 8 years ago

I personally do not use the spell check in CKeditor. But perhaps one day a client might want or expect this feature? I would not need it enabled out-of-the-box but would prefer it to be there as an option.

robertfabian commented 8 years ago

I'm the (relatively) naive user who raised questions about CKeditor. My concern is with the out-of-the-box experience. Many potential users will have experience using CKeditor in other contexts, e.g. in Drupal 7. The Full CKeditor configuration provides a raft of buttons (not all of which work, but they're present). The impression is that the version of CKeditor installed in Backdrop is somehow limited. After investigation, I did find two real limitations - anchor refuses to stay in the row of action buttons and there is no (obvious) way to link to a file that has been uploaded using CKeditor (through use of IMCE or CKfinder). Spell checking is a nice to have feature that would flesh out the CKeditor buttons available under Backdrop (even if it's not really necessary on most desktops). Disclaimer: I've dabbled with the web since the TCP/IP network was opened to the public in '94. But working on the web has never been a major focus, certainly not back when I was an active consultant.

quicksketch commented 7 years ago

Using the browser-based one is much better in my opinion. The built-in checker will use the browser's native language and custom dictionaries, as opposed to making site-specific dictionaries.

jenlampton commented 7 years ago

Using the browser-based one is much better in my opinion.

Using the browser-based one can be problematic for many users. Even though it's enabled by default, it's easy to disable by accident (right click - disable spellcheck) and that often 'accidental' setting is remembered per-field. There are also a lot of reported problems with people using Chrome on Mac (myself included) not being able to get the browser-based OS-level spell checking to work with CKEditor, or in textfields (as opposed to text areas). On short, the browser-based spellchecker is buggy. I think we need both, so I've created https://github.com/backdrop/backdrop-issues/issues/2386

The impression is that the version of CKeditor installed in Backdrop is somehow limited.

I think this is also important to take into consideration.

quicksketch commented 7 years ago

There is a PR for the browser-based approach at https://github.com/backdrop/backdrop-issues/issues/2386, which is a one-liner fix.

jenlampton commented 7 years ago

yep, let's do that first :)

Gormartsen commented 7 years ago

I use http://grammarly.com/ plugin.

jenlampton commented 5 years ago

I'm going to postpone this issue since after allowing browser spellcheck to work, we haven't gotten any more requests for a spell checker.