Add tests for file management deletion pages

backdrop / backdrop-issues

Issue tracker for Backdrop core.

144 stars 40 forks source link

Add tests for file management deletion pages #2455

Open quicksketch opened 7 years ago

quicksketch commented 7 years ago

https://github.com/backdrop/backdrop-issues/issues/2375 added a file management view and a UI for deleting files (in bulk or individually). However this functionality does not yet have test coverage. We should cover the tests and check the usage messages are accurate.

PR by @jenlampton: https://github.com/backdrop/backdrop/issues/1719 (merged, tests individual file delete)
No PR yet for bulk file deletion tests.

jenlampton commented 7 years ago

I added tests for the file management view in the main issue. Is this issue just for the confirm forms, is that what needs testing?

quicksketch commented 7 years ago

I added tests for the file management view in the main issue. Is this issue just for the confirm forms, is that what needs testing?

Yes, that's right. :)

quicksketch commented 7 years ago

Thanks! I have merged https://github.com/backdrop/backdrop/pull/1719, as it adds a test for individual file deletion.

I'm leaving this issue open however because it only partially solves the issue. Bulk file deletion is still entirely untested.

quicksketch commented 7 years ago

I found a random failure may occur in these latest tests due to sorting by timestamp, but the files are created all at the same time and so may end up out of order. Filed a fix for this at https://github.com/backdrop/backdrop/pull/1755.

quicksketch commented 7 years ago

Merged https://github.com/backdrop/backdrop/pull/1755 for 1.6.0.

jenlampton commented 7 years ago

Do we still need tests for bulk file deletion?