backdrop / backdrop-issues

Issue tracker for Backdrop core.
144 stars 40 forks source link

Upscaling in out-of-the-box image style 'Large'. #3232

Open Graham-72 opened 6 years ago

Graham-72 commented 6 years ago

Describe your issue or idea

The out-of-the-box settings for content type 'Post' have the format of the display of the image field set to 'Image style: Large' and the setting for this image style allows upscaling. If the user is unaware of this it can be a surprise, particularly if the user puts a constraint on the dimensions of the uploaded image field.

Steps to reproduce (if reporting a bug)

Either upload an image smaller than 800x600 in the image field for a post or set a constraint on the image field so that in uploading the image is scaled to a size smaller than 800x600.

Actual behavior (if reporting a bug)

The smaller image will be upscaled with consequent loss of resolution.

Expected behavior (if reporting a bug)

I would expect the image not to be upscaled by default.

Graham-72 commented 6 years ago

I think perhaps the same change should be made for the medium style. In my view upscaling should only be allowed in special circumstances, not by default.

ghost commented 5 years ago

Hmm, seems to me this depends on the use case... If you set a height and width so that all uploaded images are the same, then upscaling is what you want. But if they're just to prevent large images being stored on the server, then upscaling should likely be off. Depends what use case core is trying yo solve...

olafgrabienski commented 5 years ago

If you set a height and width so that all uploaded images are the same, then upscaling is what you want.

The image styles in use for Posts allow upscaling. @Graham-72 Would you suggest to use other image styles, or to change them?