Open jenlampton opened 5 years ago
I've seen use cases with customers where they'd want the option to schedule publishing of pages (and other content types as well). Any specific reason why we should not allow this by default for all content types?
Because it's uncommon, and not hard to enable.
Fair enough. Adding the "needs metrics" tag; not for the decision to implement this; just because it will be a good candidate to test #285
@stpaultim I would like to work on this issue.
Thank you for working on this @mmachinen 🙏🏼 ...there are test failures that need to be fixed, so I'm setting this back to "needs work". It seems to me that things should be fixed in the testPagePreview()
function/method, since it seems to be using the page
content type in order to test scheduling among other things. I haven't tested, but changing things like these should do it (there might be other additional bits here and there though):
$this->backdropPost('admin/structure/types/manage/page', $edit, t('Save content type'));
$this->backdropGet('node/add/page');
$this->backdropPost('node/add/page', $edit, t('Preview'));
PS: Once #5236 is merged, you should rebase your PR branch (let us know if you need help with that), which should help to display these failures in a better format 😉
@jenlampton re this:
Because it's uncommon, and not hard to enable.
We're basically trying to remove one of the radio options from this UI here:
I'm not sure how much value this adds, as it doesn't declutter things much. Besides, I'm concerned about making an awesome feature (WordPress parity) less discoverable, plus working with government agencies I see that it is in fact used quite a lot (ministerial announcements that are not necessarily blog posts, new members of the department that need to be announced and added to the team members listing during a specific date/time after elections, new laws/regulations that come into effect after a specific date/time etc.). Perhaps we should reconsider this?
I do govt work too, and they schedule lots of types of content, just as you mentioned, but never pages. It's easy to find this option when creating a new content type. I still feel strongly that we don't need it on Page.
On Thu, Oct 7, 2021, 2:07 AM Greg Netsas @.***> wrote:
@jenlampton https://github.com/jenlampton re this:
Because it's uncommon, and not hard to enable.
We're basically trying to remove one of the radio options from this UI here: [image: image] https://user-images.githubusercontent.com/2423362/136353864-27b564b9-35c2-4678-821c-2717a5eb4c4f.png
I'm not sure how much value this adds, as it doesn't declutter things much. Besides, I'm concerned about making an awesome feature (WordPress parity) less discoverable, plus working with government agencies I see that it is in fact used quite a lot (ministerial announcements that are not necessarily blog posts, new members of the department that need to be announced and added to the team members listing during a specific date/time after elections, new laws/regulations that come into effect after a specific date/time etc.). Perhaps we should reconsider this?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/backdrop/backdrop-issues/issues/3795#issuecomment-937600284, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADBERZ6XGBF7PPQMR7PJQTUFVPNZANCNFSM4HNY6K7Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
Well, the default when creating a new content type is to have the scheduling option shown. So I'm OK with this change here I guess.
In the standard install profile, the
Show option for scheduling
setting for Pages should be disabled. (It should remain enabled for Posts)Files to change
core/profiles/standard/standard.install
, line 123Documentation https://docs.backdropcms.org/api/backdrop/core%21profiles%21standard%21standard.install/function/standard_install/1
Related https://github.com/backdrop/backdrop-issues/issues/3122 separate help text for publishing options