search

backdrop / backdrop-issues

Issue tracker for Backdrop core.
144 stars 39 forks source link

Merge commits from Link 7.x-1.5 (and 7.x-1.6) #4055

Open jenlampton opened 4 years ago

jenlampton commented 4 years ago

This list generated with: git log 7.x-1.4..7.x-1.5 --reverse --no-merges --pretty=format:"- [ ] #xx | [%h](https://git.drupalcode.org/project/link/commit/%h) | [%s](http://drupal.org/node/)"

klonos commented 3 years ago

351670d | Issue #2843813: Fix failing tests due to missing 'administer fields' permission

This is not applicable to us; the protected $permissions array in class LinkBaseTestClass within our link.test file already includes the 'administer content types' permission, and that is what's being used in the rest of the link.* tests.

klonos commented 3 years ago

5121965 | Issue #2888461: Clear variable "link_extra_domains" on uninstall

This is also not applicable to us. See link_update_1000() and link_update_1001() and the comments re Link no longer has any config in Backdrop.

update_variable_del('link_extra_domains'); was specifically removed from link_update_1000() with https://github.com/backdrop/backdrop/commit/5f10c4cd7b5ea11ebd5b88fa2c62d460e0c0ddad#diff-d29e5fcceede04c547aa6b97a8ea269db0c950f75a82c0d9cf6a5af33aa36c0cL61

klonos commented 3 years ago

b8d9338 | Issue #2888510: Create tip for token on install

This commit in Link 7.x was simply adding this:

function link_install() {
  // Notify the user they may want to install token.
  if (!module_exists('token')) {
    drupal_set_message(t('If you install the <a href="!url" target="blank">Token</a>, static title can use any other entity field as its value.', array(
      '!url' => 'http://drupal.org/project/token',
    )));
  }
}

...but with token being baked into Backdrop core, and not a separate module, this does not apply to us.

klonos commented 3 years ago

3a22e7f | Issue #2578521: Validation error

Does not apply to us, since domain validation was removed from the Link module in Backdrop core, with https://github.com/backdrop/backdrop/commit/5f10c4cd7b5ea11ebd5b88fa2c62d460e0c0ddad#diff-fb3b913f72a04dbe75122117c4c9c8264199da44f2f8b6b1ffbb9ba54a8f5847L13

The bug report in https://www.drupal.org/node/2578521 said:

http://www.eitb.eus/es/ considered not valid URL on field validation.

Which I just tested and confirmed that no validation errors are thrown in Backdrop 👍

Similarly N/A to us:

jenlampton commented 3 years ago

Thanks @klonos! For any commit that is N/A for us can you please tick the item off the list?

klonos commented 3 years ago

I need help with c6bbf42 | Issue #1909788: Add an entity token for the display_url

This seems like a new feature(?). From the issue description in d.org:

It would be incredibly useful to have an entity token available for the display_url. [node:field-link:url] strips the query string from the URL, which makes it difficult to use it as a replacement in Linked Field, Views and elsewhere.

When adding a link field to a content type though, the only token I see available in Backdrop is [node:field_link]:

image

...and it's the same in D7, with the respective 7.x versions of token/link/pathauto:

image

What am I missing here? How do we get these :url tokens?

jenlampton commented 3 years ago

The commit shows one file changed -- and nothing relating to tokens:

https://git.drupalcode.org/project/link/commit/c6bbf42

klonos commented 3 years ago

I've split #4970 into its own issue, since it's a new feature, and I've ticked it off the list here. If there are commits between 7.x-1.4 and 7.x-1.7 of the Link module that touch that feature, then lets include them in the PR for that issue.

herbdool commented 3 years ago

@klonos RTBC on https://github.com/backdrop/backdrop/pull/3543

herbdool commented 3 years ago

I've created https://github.com/backdrop/backdrop-issues/issues/5000 and linked it above to "protocol-less..." issue.

jenlampton commented 3 years ago

Issue 5000! :)