Drupal 7.33

[jenlampton]

• [x] | https://github.com/backdrop/backdrop/pull/565 | b558549 | Issue #2318981 by grisendo: Make hook_node_grants and hook_node_access_records sample function bodies consistent
• [x] | https://github.com/backdrop/backdrop/pull/558 | 8af676d | Issue #2324083 by er.pushpinderrana, martin_q: Fix up description of return value from drupal_array_get_nested_value()
• [x] | https://github.com/backdrop/backdrop/pull/558 | 29a0dc3 | Issue #993186 by joshi.rohit100, moshe weitzman | webchick: Node access rebuilds should go newest to oldest (fix for direct node access rebuilds only, not rebuilds done via a batch).
• [x] | https://github.com/backdrop/backdrop/pull/557 | 99c124d | Issue #1468210 by marthinal, quicksketch, tstoeckler, Devin Carlson, David_Rothstein, Eric_A: Fixed Remove special $user->uid == 1 check in file_validate_size().
• [x] | N/A | 0867207 | Issue #1890980 by amitgoyal, robinvdvleuten: Fixed Unnecessary extra output variable in theme_links.
• [x] | https://github.com/backdrop/backdrop/pull/621 | be54be0 | Issue #1859084 by Jorrit, David_Rothstein, attiks: Improved database queries generated by EntityFieldQuery in the case where delta or language condition groups are used, to reduce the number of INNER JOINs.
• [x] | https://github.com/backdrop/backdrop/pull/565 | 2200030 | Issue #2277281 by dobe, amitgoyal, michaelfavia, er.pushpinderrana, dcam | drumm: Increase the maximum number of characters on the file field allowed extensions setting from 128 to 256.
• [x] | https://github.com/backdrop/backdrop/pull/565 | 8a6142a | Issue #1166114 by jhodgdon, tomogden, Rajendar Reddy, larowlan, swentel, splatio, erics14, MF82 | RobLoach: Renamed the "Search result" view mode to "Search result highlighting input" to better reflect how it is used.
• [x] | https://github.com/backdrop/backdrop/pull/621 | 3bd008b | Issue #2334689 by er.pushpinderrana, joachim: Document character limit on lock_aquire() for lock name
• [x] | https://github.com/backdrop/backdrop/pull/621 | 5b99e31 | Issue #2314181 by roderik, er.pushpinderrana, hefox: Fix docs for drupal_static
• [x] | https://github.com/backdrop/backdrop/pull/621 | 8d1e516 | Issue #2340675 by er.pushpinderrana, David Hernández: Clarify first, unused argument docs in update_calculate_project_update_status()
• [x] | https://github.com/backdrop/backdrop/pull/621 | f2c8d95 | Issue #2283675 by er.pushpinderrana, amitgoyal, mparker17, joachim, mmarquez: Document how optgroups are generated in form_select_options()
• [x] | N/A | 131a6f5 | Drupal 7.32 Tag
• [x] | https://github.com/backdrop/backdrop/pull/621 | 57236b0 | Issue #2329189 by nlisgo, joachim, Mirroar, opdavies: Fix up docs and example code for hook_field_attach_validate()
• [x] | https://github.com/backdrop/backdrop/pull/621 | 4a93ebd | Issue #667098 by catch, chx, plach, Fabianx: Fixed a bug which caused drupal_get_bootstrap_phase() to abort the bootstrap when called early in the page request.
• [x] | https://github.com/backdrop/backdrop/pull/608 | 5f380f9 | Issue #2332295 by sanduhrs, klausi, er.pushpinderrana, Berdir | jfha73: Fixed Unicode requirements check not working with PHP 5.6.
• [x] | N/A | fa2e36b | Issue #2301955 by er.pushpinderrana, lokapujya | scor: Ensure RDFa metadata tags are hidden.
• [x] | N/A | 4d5a0ad | Issue #1323830 by cwells, scor, mgifford, er.pushpinderrana, kay_v: Place title RDFa metadata inside entity HTML element.
• [x] | N/A | 3a4f085 | Issue #2130673 by lokapujya, cwells | scor: Place number of comments metadata inside node template.
• [x] | https://github.com/backdrop/backdrop/pull/621 | 6b7514a | Issue #829464 by Berdir, klausi, sepgil | Heine: Fixed orderby() should verify that the sort direction is always ASC or DESC.
• [x] | N/A | ac66040 | Issue #2291081 by pounard: forum_node_view attempt an unnecessary vocabulary_load() under certain circumstances.
• [x] | N/A | e9bca3a | Issue #1182374 by lyricnz, xendil, sivaji, brianV: Code style fixes for includes/filetransfer.
• [x] | https://github.com/backdrop/backdrop/pull/621 | 62c952c | Issue #1183708 by Liam Morland | onair1: Fixed Notice: Undefined index: favicon_path in system_theme_settings_validate().
• [x] | https://github.com/backdrop/backdrop/pull/621 | d5945c1 | Issue #208611 by p.brouwers, mgifford, tstoeckler, DougKress, Jody Lynn, ksenzee | walkah: Made the Ajax system use drupal_array_merge_deep_array() to stop JavaScript settings from being added twice.
• [x] | https://github.com/backdrop/backdrop/pull/625 | 5aede0d | Issue #1936942 by jweowu: Fixed translation_node_insert() updates the node table directly without also flushing the entity load cache.
• [x] | https://github.com/backdrop/backdrop/pull/625 | c312e5e | Issue #1968348 by znerol, David_Rothstein, peximo, DuaelFr: Fixed hook_field_formatter_prepare_view does not make use of hook_entity_view_mode_alter causing major errors.
• [x] | https://github.com/backdrop/backdrop/pull/625 | 4443a30 | Issue #2307505 by Cottser, Fabianx: Port twig_debug output to Drupal 7.
• [x] | https://github.com/backdrop/backdrop/pull/622 | d1a4193 | Issue #1988456 by gaurav.goyal, eltermann, pvmchau: Non-standard indentation on user_register_form().
• [x] | N/A | 71651db | Issue #28175 by dcam, bleen18 | bertboerland: Fixed Ordering by 'Visitor' in access log pages does not sort IP addresses.
• [x] | N/A | e052539 | Issue #2224917 by m1r1k, Steven Jones, drumm: Fixed Tracker page doesn't order results properly.
• [x] | https://github.com/backdrop/backdrop/pull/622 | 0e3d0be | Issue #1790612 by carwin, Eric_A, mgifford: Fixed Sanitize the trim_length variable before printing it.
• [x] | https://github.com/backdrop/backdrop/pull/622 | 6b47cbf | Issue #205969 by Mile23, oadaeh, twistor, ssm2017 Binder, barraponto, superspring: Fixed backdrop_http_request() assumes presence of Reason-Phrase in response Status-Line.
• [x] | https://github.com/backdrop/backdrop/pull/622 | 49a51c7 | Issue #1452896 by Mile23, marthinal, Freso, kid_icarus, joshi.rohit100, alexpott, tim.plunkett, jhodgdon: Fixed PHP notice in clickLink if link does not exist.
• [x] | https://github.com/backdrop/backdrop/pull/622 | a0561f8 | Issue #2231693 by helmo, amitgoyal, joshi.rohit100, LinL, iS: Update Powered by Drupal link.
• [x] | https://github.com/backdrop/backdrop/pull/622 | ea1c7a9 | Issue #1120440 by er.pushpinderrana | skwashd: Fixed user.api.php hook summary lines should be more consistent with other entity hooks.
• [x] | https://github.com/backdrop/backdrop/pull/622 | 90687ab | Issue #780304 by dcam, naxoc, Crell | zyxware: Fixed HTML encoding of em wrappers for database table names while showing schema errors.
• [x] | https://github.com/backdrop/backdrop/pull/622 | a28e032 | Issue #1891728 by gielfeldt: Fixed Database schema methods like getComment() and findTables() always query the "default" target on MySQL.
• [x] | N/A | c95d725 | Issue #2228825 by donquixote | pingwin4eg: Fixed drupal_get_filename() does not search the filesystem when the file isn't yet listed in the {system} table in the database.
• [x] | https://github.com/backdrop/backdrop/pull/622 | c684532 | Issue #1099732 by joshi.rohit100, droplet | Chi: Fixed Incorrect encoding for error pages in image_style_deliver().
• [x] | https://github.com/backdrop/backdrop/pull/622 | 90d6f05 | Issue #1679570 by mgifford, lucascaro, sun: Fixed TestBase does not always use the correct database connection for handling assertions.
• [x] | N/A | 417fae5 | Issue #1775488 by mgifford, vijaycs85, amateescu | chx: Fixed drupal_cron_cleanup is not converted to lock.
• [x] | N/A | 8d5c1bf | Issue #366152 by Mile23, bjaspan: Removed the Field module's field_modules_uninstalled() function, since it did not do anything when it was invoked.
• [x] | https://github.com/backdrop/backdrop/pull/625 | f68c6ce | Issue #466576 by gagarine, jackbravo, tim.plunkett, sheise, Rob C, jamesm6162 | daemon: Increased the maximum allowed length of block titles to 255 characters.
• [x] | https://github.com/backdrop/backdrop/pull/625 | bc7940a | Issue #2058761 by kirby14, thedavidmeister: PHP notice when #attributes is not set with #theme_wrappers 'container'.
• [x] | N/A | a6d70dd | Issue #908822 by jmking, asimmonds | salvis: Fixed Dashboard discards elements.
• [x] | N/A | 433fe74 | Issue #1221772 by pounard, colan, jcisio | sivaji: Fixed Transaction database settings is misleading in settings.php.
• [x] | https://github.com/backdrop/backdrop/pull/625 | 56e257d | Issue #1854134 by EtienneRd, jeffam | dolu: Added a query tag to the query in menu_link_get_preferred() to allow modules to alter the query.
• [x] | https://github.com/backdrop/backdrop/pull/625 | 2a4f67c | Issue #1824820 by crevillo, muriqui, a.milkovsky, Phizes: Fixed String offset cast notice in field_invoke_method_multiple().
• [x] | https://github.com/backdrop/backdrop/pull/625 | 355446d | Issue #1195358 by Liam Morland, droplet: Fixed Multiple "Edit/Hide summary" links appear.
• [x] | https://github.com/backdrop/backdrop/pull/625 | 2e235b5 | Issue #849624 by brad.bulger, dcam, Alan Evans, oriol_e9g, Stevel | tsvenson: Fixed wrong permission for admin/structure/menu/parents.
• [x] | https://github.com/backdrop/backdrop/pull/625 | 766312e | Issue #1640404 by er.pushpinderrana, dcam, amit.drupal, hass | versvs: Fixed Use format_username() in node_feed().
• [x] | N/A | 010a9a5 | Issue #2324821 by rpayanm, er.pushpinderrana | Elijah Lynn: Remove reference to nonexistent theme_poll_bar() function in template_preprocess_poll_bar() documentation.
• [x] | N/A | 0c8dc6e | Issue #1823906 by joshi.rohit100, amitgoyal, rahulbile | gargsuchi: Fixed Incorrect error message when poll is submitted with no option selected.
• [x] | https://github.com/backdrop/backdrop/pull/631 | 62e874b | Issue #1071818 by JeremyFrench, nod_, Cottser, gielfeldt, xjm, anthbel, reglogge, NROTC_Webmaster, kristofferwiklund, lliss, sun | sepgil: Fixed Lazy-loading CSS fails in IE.
• [x] | https://github.com/backdrop/backdrop/pull/631 | 9ebc7af | Issue #1913958 by hass, YesCT: Fixed Bartik theme shouldn't change capitalization of translatable strings with CSS.
• [x] | https://github.com/backdrop/backdrop/pull/631 | f7cf579 | Issue #1069152 by droplet, alexandrezia, Mixologic, jhedstrom | ogi: Fixed Throbber in textfield is often misaligned.
• [x] | N/A | 0b4c3b1 | Issue #2357311 by penyaskito: Fixed Follow-up to SA-CORE-2014-005 (tests don't work correctly on non-MySQL databases).
• [x] | https://github.com/backdrop/backdrop/pull/631 | c401ec3 | Issue #2112247 by sihv, mitsuroseba, dgroene, aalamaki, Dennis Walgaard, mErilainen: Fixed Valid file extensions in file names are not properly enforced when uploading files with non-lowercase names.
• [x] | N/A | af4cde1 | Issue #2193149 by mikeytown2: Fixed Deadlocks occur in cache_field table.
• [x] | https://github.com/backdrop/backdrop/pull/631 | c2b05dd | Issue #2142441 by Garrett Albright: Fixed CSS aggregator prepends data: URLs with paths.
• [x] | https://github.com/backdrop/backdrop/pull/631 | f609f39 | Issue #1231710 by cs_shadow, Hydra, dcam, kathyh, klausi, mlncn: Fixed Field exceptions should return the name of the field that has exceptions.
• [x] | https://github.com/backdrop/backdrop/pull/631 | 8cf521c | Issue #1443070 by CrashTest_, bluegriff | Dave Reid: Added support for popular e-book formats, Google web formats, mkv and mka in file_default_mimetype_mapping().
• [x] | https://github.com/backdrop/backdrop/pull/631 | e7b2772 | Issue #2278583 by nlisgo, Berdir, joshi.rohit100 | Fabianx: Fixed field_has_data looks at current data instead of revisioning data: this can lead to data loss.
• [x] | https://github.com/backdrop/backdrop/pull/631 | d7ea3ba | Issue #2356055 by bdlangton: Fixed Notice in includes/mail.inc define.
• [x] | https://github.com/backdrop/backdrop/pull/631 | 037848a | Issue #935592 by pillarsdotnet, lokapujya, David_Rothstein, John Franklin, amitgoyal, joshi.rohit100, sivaji, mgifford, peximo, wodenx, Romlam, Owen Barton, alpritt, beejeebus | macgirvin: Fixed User picture is deleted after calls to user_save().
• [x] | https://github.com/backdrop/backdrop/pull/673 | 1b82c57 | Issue #1433288 by haggins, fago, David_Rothstein, marcin.wosinek: Fixed Integrity constraint violation when saving a user account after creation.
• [x] | https://github.com/backdrop/backdrop/pull/673 | c8a26f2 | Issue #927138 by manarth, handrus, rasmusluckow, douggreen, .John, Taz, David_Rothstein, droplet, webchick, marcingy: Fail image generation with 404 instead of 500 when source file is missing.
• [x] | https://github.com/backdrop/backdrop/pull/673 | d6c5029 | Issue #779374 by helmo, joshi.rohit100, meba, sun | coltrane: Fixed XSS via text format names.
• [x] | N/A | 9559160 | Issue #1930960 by pounard, iamEAP, pjcdawkins, msonnabaum, David_Rothstein: Fixed Block caching disable hardcoded on sites with hook_node_grant() causes serious performance troubles when not necessary.
• [x] | N/A | b09c678 | Issue #863594 by David_Rothstein, smussbach, mbrett5062: Fixed Strange first paragraph in the installer database error message.
• [x] | https://github.com/backdrop/backdrop/pull/673 | af79dc0 | Issue #1069152 by droplet, alexandrezia, Mixologic, jhedstrom, David_Rothstein | ogi: Fixed Throbber in textfield is misaligned when browser hardware acceleration enabled (followup for Bartik RTL styling).
• [x] | N/A | ebf478b | Issue #1338966 by geerlingguy, loganfsmyth, lokapujya: Fixed Introduce _rdf_mapping_load_multiple to reduce queries.
• [x] | https://github.com/backdrop/backdrop/pull/673 | b73583f | Issue #393538 by Liam Morland, valthebald, dmitrig01, David_Rothstein: Document that check_plain() can issue PHP messages on invalid UTF-8 input.
• [x] | https://github.com/backdrop/backdrop/pull/673 | cd38268 | Issue #2310415 by cilefen, ednawig, TravisCarden: Fixed run-tests.sh does not handle the error when invalid test groups/classes are specified.
• [x] | https://github.com/backdrop/backdrop/pull/673 | 6cf3889 | Issue #2147321 by manfer: Fixed Unnecessary space in session-active class.
• [x] | https://github.com/backdrop/backdrop/pull/673 | 2e906b8 | Issue #2282541 by Mark Carver | gge: Fixed Hide summary in text.js not working in jQuery 1.9+.
• [x] | https://github.com/backdrop/backdrop/pull/673 | 35e7cb1 | Issue #892344 by amitgoyal, tstoeckler, hussainweb, pcambra, LaurentAjdnik: Fixed Wrong schema description for {cache_field}.
• [x] | https://github.com/backdrop/backdrop/pull/673 | c990cd6 | Issue #1355526 by cafuego, jenlampton: Added a way to determine the date a module was added so the modules page can use it for sort.
• [x] | N/A | 0091b69 | Issue #2305291 by scor: Fixed Poll title should have same length as regular content type (255).
• [x] | N/A | abb166c | Various updates to CHANGELOG.txt in preparation for the 7.33 release.
• [x] | https://github.com/backdrop/backdrop/pull/673 | 86a1ebe | Issue #2307505 by Cottser, David_Rothstein, Fabianx: Followup to ensure all theme debug output is properly sanitized.
• [x] | N/A | caff8dd | Added issue #2310415 to CHANGELOG.txt.

Follow-up issues

• https://github.com/backdrop/backdrop-issues/issues/583 | df8de73 | Issue #1918820 by neclimdul, typhonius, girishmuraly, pwolanin | 0x534B41: Fixed HTTP header date formats to follow RFC 7231 rather than RFC 1123.

The command for generating this list was: git log b558549.. --reverse --no-merges --pretty=format:"- [ ] | #xx | [%h](http://drupalcode.org/project/drupal.git/commit/%H) | [%s](http://drupal.org/node/)"

where the commit b558549 is the starting point.

[juanolalla]

0867207 | Issue #1890980 by amitgoyal, robinvdvleuten: Fixed Unnecessary extra output variable in theme_links.

This is already fixed in Backdrop code: https://github.com/backdrop/backdrop/blob/1.x/core/includes/theme.inc#L1745-L1749

[jenlampton]

@juanolalla Thanks! There may be a handful of those in here. When that's the case just 1) check the box, 2) replace the #xx with N/A and 3) move on to the next issue :)

[scotself]

Was trying to install the newest version as of today and ran into 5f380f9 | Issue #2332295 by sanduhrs, klausi, er.pushpinderrana, Berdir | jfha73: Fixed Unicode requirements check not working with PHP 5.6.

Since I was able to apply this patch https://www.drupal.org/files/issues/drupal7-unicode_requirements-2332295-23.patch no problem but don't see how to mark one off here if I were to try and apply this to backdrop (or any others). What am I missing? Would love to help out and apply this one and maybe more in the future.

[quicksketch]

Hi @scotself! Could you file a pull request via the instructions/video at https://backdropcms.org/develop/pull-requests? I've invited you as a docs/organization member so you'll be able to edit the issue summary to point at your new PR. We'll check them off after they've been merged. Thanks!

[quicksketch]

Merged the first set from https://github.com/backdrop/backdrop/issues/621. Thanks @jenlampton!

[quicksketch]

Another couple PRs merged from https://github.com/backdrop/backdrop/issues/625 and https://github.com/backdrop/backdrop/issues/661. 16 left to go, though I'm not sure many of them actually apply to Backdrop.

[jenlampton]

12 apply. Final PR filed.

[quicksketch]

Filed a new replacement PR at https://github.com/backdrop/backdrop/pull/673, this should get the rest of them now.

[quicksketch]

Yay, tests passed and we're merged with the last set. Thanks!