Closed indigoxela closed 1 week ago
Still "discussing" with Zen.CI...
Anyway, a PR is available for testing and review.
BTW: I don't think that it's a good idea to use translated strings as array keys, but the same concept is used in function config_export_single_form(), or actually in config_get_prefix_groups().
Still "discussing" with Zen.CI...
IKR? 🤦 😞
Rebased this incredibly old PR - the bugfix is still valid. Don't have high hopes for attention here, but if someone needs a solution - here it is. :grinning:
Not that I think, using a translated string as GET param is smart in any way, but... :shrug:
I followed the steps reported in the issue summary. I tried translating a string without translation in the language I added, and changing an existing translation for the same language. I did not get any error shown in the user interface.
Thanks @indigoxela and @avpaderno! Strange fix for sure. I wouldn't say no to a more comprehensive fix that didn't use translated strings but that might be a lot more challenging. I merged https://github.com/backdrop/backdrop/pull/3432 into 1.x and 1.28.x as-is. Thank you!
Description of the bug
When trying to export a user role config, when following a link on the role overview page, PHP notices and warnings are thrown, if a language other than English is the current one and the string "User roles" has a translation.
Steps To Reproduce
UPDATE: 4 years later the message slightly changed, but the base problem persists and the fix is still valid.
New notice:
Additional information