"Undefined index: distribution_name" for Drupal migrations if profile is not "standard"

[ghost]

If a Drupal site is upgraded to Backdrop and the install profile is not "standard" there are several php notices. This is because the installation doesn't run and 'distribution_name' doesn't get set. However when we get that information from the profile info file, we assume it's there and don't allow for instances where it doesn't exist. Then users get the following notice:

Notice: Undefined index: distribution_name in backdrop_install_profile_distribution_name() (line 222 of [SNIP]\core\includes\install.inc).

And also:

Notice: Undefined index: name in system_requirements() (line 33 of .../core/modules/system/system.install).
Notice: Undefined index: version in system_requirements() (line 35 of .../core/modules/system/system.install).

We should add a check to backdrop_install_profile_distribution_name() before attempting to return it.

[ghost]

PR: https://github.com/backdrop/backdrop/pull/3436

[indigoxela]

If a Drupal site is upgraded to Backdrop then the installation doesn't run and 'distribution_name' doesn't get set

This isn't the case for "normal" Drupal installs, I guess, because I wasn't able to reproduce it.

@BWPanda can you provide the steps to reproduce?

[ghost]

No, I didn't test it, just based my assumptions off the code and a report in the forum...

[klonos]

Edit: moved the testing steps over to #4801

No, I didn't test it ...

I'm hoping that we can refine the steps in #4801, so that we have easy to reuse steps to test vanilla D7 to Backdrop upgrades.

[indigoxela]

Another test, this time I could reproduce it, because I installed the minimal profile. My steps in detail:

Drupal:

• Installed minimal profile (minimal-7.77)
• Enabled a bunch of modules
• Added content types with fields
• Created users, terms, content with devel
• Uninstalled devel
• Made sure, error display is on
• Took database dump

Backdrop:

• Installed a fresh Backdrop 1.18.x-dev
• Copied the content of the Drupal files directory to that web
• Dropped and recreated (empty) database of that Backdrop
• Imported the Drupal db dump
• $settings['update_free_access'] = TRUE;
• ran core/update.php (193 pending updates)
• Back to $settings['update_free_access'] = FALSE;

Final steps:

• Logged in, got several Undefined index notices
• Enabled Project Installer module (why isn't it enabled by default?)
• Another notice "Notice: Undefined index: distribution_name"
• Ran utf8mb4 conversion
• Changed Public file system path (forgot to do that before)
• Ran cron (updates for images)

Notice: Undefined index: distribution_name still shows up on admin/modules/list Notice: Undefined index: name/version still shows up on admin/reports/status

Applied the PR patch

Notice: Undefined index: distribution_name is gone Notice: Undefined index: name/version still shows up on admin/reports/status

The remaining messages:

    Notice: Undefined index: name in system_requirements() (line 33 of .../core/modules/system/system.install).
    Notice: Undefined index: version in system_requirements() (line 35 of .../core/modules/system/system.install).

Besides the notices because it's not the standard profile, everything went smoothly.

[indigoxela]

@BWPanda I now reverted the patch and keep this testing web in that state to further test your PR after changes/updates.

Let's see how we make the notices go away. One down, two to go. :wink:

[ghost]

Thanks @indigoxela! Are those last two notices not part of https://github.com/backdrop/backdrop-issues/issues/2518? Maybe we should fix those there instead if so...

[indigoxela]

Are those last two notices not part of #2518?

Hm, good question, isn't this issue here a duplicate of that older one?

[ghost]

This is about the distribution name notice, that was about the other two notices.

[indigoxela]

This is about the distribution name notice

Sure, but the root cause for all three notices is the same: profile is not standard. The fact that distribution_name isn't mentioned over there might just have been an oversight.

Your current PR only suppresses the notice, but doesn't solve the base problem. I agree with that comment by @klonos. We really should handle this better, otherwise upgrading from D7 could cause unnecessary pain.

[alanmels]

Please note https://github.com/backdrop-contrib/profile_switcher module had been ported to Backdrop a while ago.

[jenlampton]

~The underlying problem here is that we're checking the list of modules for a profile, but we have type = profile in the profile's .info file so the profile doesn't qualify as a "module".~

Maybe not, in the system table the profiles sill register as modules... but it also shows minimal as disabled? Before the upgrade, in the Drupal 7 database minimal was enabled. I think we might be disabling profiles by accident, thinking they are modules.

[jenlampton]

Well, I just ran the upgrade again and it started enabled, and ended enabled. I don't know what's going on here. But once minimal was enabled I didn't get any of the undefined index issues.

[ghost]

I previously added a branch to the core repo with my PR changes, which was naughty. So I've deleted it. Need to start again with a branch in my personal fork (or someone else can take over).

[klonos]

I'm tentatively adding this to my to-do list ...unless someone else beats me to it.

[klonos]

Should we close this as a duplicate of #2518?