Dropdown menu flickering

olafgrabienski commented 2 years ago

Description of the bug

The default header dropdown menu flickers sometimes when you use the menu links.

Steps To Reproduce

To reproduce the behavior:

Add three or more pages to a fresh Backdrop site, put them as menu items in the Primary navigation under the "About" item.
Go to the home page. Click the "Home" menu item several times, e.g. 15 times.

Actual behavior

The "About" sub-menu shows up for a quite short time, and disappears again – it 'flickers'.

Note: This doesn't happen on every page load. Also, the visibility of the issue depends on factors like server performance, bandwidth and browser. To reproduce the issue more easily, you may enable bandwidth throttling using the browser dev tools.

Expected behavior

No flickering.

Additional information

Add any other information that could help, such as:

Backdrop CMS version: latest 1.22
Web server and its version: various
Operating System and its version: Mac OS
Browser(s) and their versions: Chrome, Firefox (less visible)
Reported first at https://forum.backdropcms.org/forum/dropdown-menu-flickering-when-navigating-between-pages
Zulip discussion: https://backdrop.zulipchat.com/#narrow/stream/218635-Backdrop/topic/Menu.20flickering/near/284589000

indigoxela commented 8 months ago

Done!

Excellent! This seems good to go now. :+1:

quicksketch commented 8 months ago

Thanks everyone! I really appreciate the exhaustive testing and the thoughtful solutions presented here. I merged https://github.com/backdrop/backdrop/pull/4602 into 1.x and 1.26.x.

https://github.com/backdrop/backdrop/commit/f2aabf719c8c6602c8b8225c5044752f4dfe4c30 by @argiepiano, @indigoxela, @olafgrabienski, @richrda78, @mikesoltis, @laryn, and @klonos.

backdrop / backdrop-issues