Fix minor spelling mistake in views plugins documentation.

backdrop / backdrop-issues

Issue tracker for Backdrop core.

144 stars 39 forks source link

Fix minor spelling mistake in views plugins documentation. #5772

Closed laryn closed 1 year ago

laryn commented 1 year ago

Description of the bug

I was looking through views_plugin_argument_default_current_user.inc and happened to notice a small spelling mistake. I did a search for odes and found this spelling mistake also exists in views_plugin_argument_default_node.inc.

This plugin actually has no options so it odes not need to do a great deal.

Should be:

This plugin actually has no options so it does not need to do a great deal.

see

vedsom commented 1 year ago

hey @jenlampton @laryn can you assign me this task. I can solve this issue under hactoberfest.

vedsom commented 1 year ago

hey, @bugfolder can you elaborate a little on which folder docs I have to work n?

indigoxela commented 1 year ago

Hi @vedsom,

the folders are core/modules/node/views/ and core/modules/user/views/, both affected files are linked in the issue description.

vedsom commented 1 year ago

Hey, @indigoxela I have solved the problems of the affected files and created a PR. Have a look!!!

indigoxela commented 1 year ago

@vedsom many thanks for your PR :pray:

A straight forward, comment only spelling fix, RTBC! :+1:

vedsom commented 1 year ago

@vedsom many thanks for your PR 🙏

A straight forward, comment only spelling fix, RTBC!

@indigoxela Sorry didn't get it, do i have to comment spelling fix in pr??

indigoxela commented 1 year ago

didn't get it, do i have to comment spelling fix in pr??

Maybe my wording wasn't ideal - yes, your spelling fix is in a docblock comment. :wink:

vedsom commented 1 year ago

didn't get it, do i have to comment spelling fix in pr??

Maybe my wording wasn't ideal - yes, your spelling fix is in a docblock comment. 😉

No worry I respect your work. Is it fine now I have updated the comment.

indigoxela commented 1 year ago

Is it fine now I have updated the comment.

Now I'm confused - it has always been fine. No need for an update.

I'll give it another try to more clearly explain what I meant:

You fixed a problem
You fixed it in a comment (you PR change is within a php comment (documentation blocks are (technically) code comments)
As it's inside a comment, there's no need to test anything (no change in functionality)
There's nothing to do for you @vedsom - you did everything right
Someone with enough permissions can merge it into core

vedsom commented 1 year ago

@indigoxela Ok so i have nothing to do, everything is correct and someone will merge it in upcoming time right!!

klonos commented 1 year ago

Yes @vedsom, your PR has been approved and is ready to be merged by one of our core committers. Nothing else that needs to be done on your end.

Thank you for contributing 🙏🏼

vedsom commented 1 year ago

Yes @vedsom, your PR has been approved and is ready to be merged by one of our core committers. Nothing else that needs to be done on your end.

Thank you for contributing 🙏🏼

@klonos It's is part of hactoberfest??

laryn commented 1 year ago

Thanks @vedsom @indigoxela and @klonos -- merged into 1.x and 1.23.x. And special thanks for your first contribution @vedsom! :tada: