[UX] File management: "Replace file" doesn't really replace the file

[klonos]

Description of the bug

When replacing a managed file with a different one with identical filename, the original file is not really replaced.

Steps To Reproduce

To reproduce the behavior:

1. Prepare a .png file on your local, and name it either card3-organize.png or card2-card.png or card1-layout.png.
2. Navigate to admin/content/files and depending on the filename you chose in the previous step, click the "Manage" button of the respective file in the "Manage files" list.
3. In the file manage form, use the "Replace file" field to upload the file from step 1, and save.
4. Go to the home page of the site, and verify that the file is replaced 👍🏼
5. Inspect the page, or right-click the newly-uploaded image and open in a new browser tab. Notice how the file was actually renamed to card3-organize_0.png (or card2-card_0.png or card1-layout_0.png) instead of replacing the original file and keeping the same file name 👎🏼
6. Navigate to admin/content/files and click "Manage" for the file you replaced.
7. Click the "View" tab at the top. The old image file is shown 👎🏼

Some additional UX confusion:

1. Navigate to admin/structure/file-types/settings.
2. Notice the "Keep original file name" setting in the "File replace options" section, and the help text:

   Rename the newly uploaded file to the name of the original file. This action cannot be undone.

Actual behavior

• Instead of the file being replaced with the new one of the same filename, the new one is renamed, and the old file is retained 👎🏼
• When managing the file, the old file is previewed/rendered, and the new file cannot be accessed via admin/content/files 👎🏼

Expected behavior

• The newly-uploaded file actually replaces the old one.
• When managing and then viewing the file (entity), the new file should be reflected.

Additional information

Drupal has similar odd UX (see https://www.drupal.org/project/drupal/issues/2648816 and related issues), which can be addressed by means of modules like these:

• https://www.drupal.org/project/file_replace

  The file replace module is a small utility providing site administrators with the possibility to replace files, keeping the file uri intact. This is useful in cases where a file is linked or used directly but needs to be updated occasionally.

• https://www.drupal.org/project/media_entity_file_replace

  This module allows content editors to easily replace the source files associated with file-based media types (like "Document"). The replacement file overwrites the existing file, keeping the same filename and path, which is usually what content editors want to do when performing a file replacement.

  

[klonos]

...clearing caches and running cron does not fix the problem above. Perhaps it relies on the garbage collection, and the file is removed after 6 hours (I'll check again).

[izmeez]

This may be related to why with hero block with background, removing the background doesn't really remove the file. There is no replace file option. Adding the replacement file is renamed because the original file had not been removed. I thought I created an issue?

[stpaultim]

I experienced a similar problem the other night. I uploaded a bunch of images using the wrong file set. I thought I would be able to simply replace them with the correct ones, but it did not work at all. I had to delete the original image entity and create a new one.

I know that this is not exactly the same problem and that I have not provided steps to reproduce my problem yet. I will try to do so soon. But, it was a very frustrating problem and seems like it's related to this one. I need to figure out how it's related.