[UX] Project Browser: The default sorting is indicated as "Relevance" when it is in fact "Most installed"

[klonos]

NOTE: This problem only happens once; when first visiting that page after a fresh installation. You cannot reproduce this at all on existing sites, and you cannot reproduce it again after you have changed the sorting even once, or have made even a single search. Odd.

Steps To Reproduce

To reproduce the behavior:

1. Vanilla Backdrop installation.
2. Go to the "Install new modules" page at admin/modules/install

If you need to reproduce the problem after testing with some filters/sorting: log out of the site, and then log back into the site. This happens because the last-used sorting/filtering is saved in the $_SESSION.

Actual behavior

Notice how the default sorting is indicated as "Relevance", however modules in that list below are actually sorted by "Most installed" (in descending order):

Expected behavior

• The default sorting of results/projects should remain "Most installed" (in descending order) when nothing has been searched/filtered/sorted. For instance, when the form loads initially, or when the "Clear" button is clicked.
• If no sorting has been manually set before, then as soon as a search by project name is performed, the filter should automatically switch to "Relevance".
• The indication in the filters should be correctly reflecting reality in any case.

[indigoxela]

That's a "known problem".

Actually, I don't think that "Relevancy" (score) has any meaning in that search. Would be great to fix that, but... :shrug: Maybe just remove it?

[klonos]

I have something working locally, but it needs some polishing before I file a PR. I'm being "pulled" into other things at the moment, so it might take 2-3 days before I loop back to this.