backdrop / backdrop-issues

Issue tracker for Backdrop core.
144 stars 40 forks source link

Re#736 - Progress Bar #758

Closed wesruv closed 9 years ago

wesruv commented 9 years ago

Blocked There are some comments related to Fieldsets at backdrop-ops/styleguide#11 Please hold off on this ticket until they are addressed there.

See master issue for instructions/guidelines for implementation: https://github.com/backdrop/backdrop-issues/issues/736

style guide backdrop

klonos commented 9 years ago

DISCO YEAH!!!

Can we please keep it simple and use an alteration of the #0494DB and #0C5E89 blues used for button normal and hover states (for the sake of color palette consistency)?

...no pun intended there with disco vs. blues :stuck_out_tongue:

Something like this perhaps:

blues_progress

generated using http://cssload.net

docwilmot commented 9 years ago

FWIW, I'm diggin the disco.

quicksketch commented 9 years ago

During our call yesterday, we agreed that the progress bar was a little too fluorescent. Darius is finding a way to tone it down a little bit.

Bojhan commented 9 years ago

This is indeed a bit much.

Its mostly the color scheme that is off, you generally don't do the color A, color B, color A, etc. approach anymore (that's kinda 99').

Some approaches:

screen shot 2015-04-22 at 10 33 33

screen shot 2015-04-22 at 10 35 01 screen shot 2015-04-22 at 10 35 26

Or the most awesome one: screen shot 2015-04-22 at 10 35 58

klonos commented 9 years ago

Or the most awesome one:

Good one!! :laughing:

dariusgarza commented 9 years ago

Updated status bar: http://codepen.io/anon/pen/VLLrRV

quicksketch commented 9 years ago

This looks a lot better. The animation is a little jumpy when it repeats, but I think that's probably an implementation issue. The current bar also only works in Chrome, but I think that's just missing the appropriate properties for other browsers.

klonos commented 9 years ago

The current bar also only works in Chrome, but I think that's just missing the appropriate properties for other browsers.

Yep, I opened the link provided above in firefox last night to check how it looks and all I got was a grey bar.

wesruv commented 9 years ago

Yeah, I think we can fix that in implementation, at minimum IE8 and some older browsers will get a green bar. All modern browsers should get a kickass smooth animation.

wesruv commented 9 years ago

@dariusgarza and whoever's interested, look good? http://codepen.io/wesruv/pen/vOOQRz?editors=010

wesruv commented 9 years ago

Here's a PR for what I came up with. Increased the height to 40px per the original styleguide, let me know if that isn't what we want in the final. https://github.com/backdrop/backdrop/pull/866

quicksketch commented 9 years ago

Thanks @wesruv! A few things I noticed in testing:

progress

BTW, we have a completely separate issue for transitions, we can close that one as duplicate if we handle it here: #643.

quicksketch commented 9 years ago

The PR at https://github.com/backdrop/backdrop/pull/866 has been closed (boo!) because I deleted the 1.x-new-style branch after we merged into 1.x (yay!) We had some feedback that needed to be addressed anyway, but when you get the chance please file again directly against the 1.x branch.

quicksketch commented 9 years ago

Thanks, this looks great @wesruv! I tested the installer and simpletest running and everything works the way I would expect. Great job!