search

backdrop / backdrop-issues

Issue tracker for Backdrop core.
144 stars 40 forks source link

[DX] rework theme_pager() #797

Open jenlampton opened 9 years ago

jenlampton commented 9 years ago

As a front-end developer, I often want to override the output of a pager, but I really struggle with finding where to override what in theme_pager().

The pager markup is generated across a number of different theme functions, and reading through theme_pager() to find what I need always ends up giving me a headache.

In Drupal 8 we managed to convert this into a template file. I wonder if doing the same in Backdrop might make this easier for developers to work with.

klonos commented 3 years ago

Can you please elaborate @jenlampton? ...that is if you recall what annoyed you 😅

ghost commented 3 years ago

Probably the same thing that confused me: https://github.com/backdrop/backdrop-issues/issues/4697

klonos commented 3 years ago

🙄 😜 ...it does need simplification/rework.

indigoxela commented 3 years ago

As a general recommendation: a one-liner hardly ever provides enough information. We should (IMO) be a better role model regarding that. We expect others to provide more detailed issue descriptions, too. :smile:

jenlampton commented 3 years ago

Yes, sorry everyone about the useless issue text. Back in 2015 I was creating issues like crazy as "todo" items for myself more than anything else -- but apparently some are still lingering in the queue!

I've rewritten my original complaint to include an explanation and possible solution.