search

backspaces / agentscript

An Agent Based Modeling system (ABM)
http://backspaces.github.io/agentscript/
GNU General Public License v3.0
106 stars 14 forks source link

broken path to fullscreen.css on some of the GIS interactions #80

Closed stephenguerin closed 1 year ago

stephenguerin commented 1 year ago

example to reproduce: run: https://code.agentscript.org/maplibre/droplets.html

and check console:

image

backspaces commented 1 year ago

Oh God, another path problem: if one module calls a function in a different module, there are issues as to "where" relative paths are evaluated Example src/Plot.js calling src/util.fetchCssStyle('../vendor/uPlot.css') The browser converts the relative url, '../vendor/uPlot.css', to. an absolute url. But that means the browser has to choose from which folder to use as the base for the conversion. This has been a bummer for quite a while. There is sorta a solution like this using: url = import.meta.resolve(url) Even it can be confused. I'll add the meta.resolve and see if it fixes things.

backspaces commented 1 year ago

OK, it looks OK. Could you try it t see if it works for you?

backspaces commented 1 year ago

I've run all the demos in leaflet and maplibre (using the runleaf & runml package.json scripts) and all pass, so I'll close this for now. @stephenguerin Let me know if you see odd behavior.

backspaces commented 12 months ago

I think this is fixed. Could you try? If it's ok, close the issue, please.

On Tue, Sep 12, 2023 at 4:00 PM Stephen Guerin @.***> wrote:

example to reproduce: run: https://code.agentscript.org/maplibre/droplets.html

and check console:

[image: image] https://user-images.githubusercontent.com/1078567/267475893-01ca3a54-e821-40ad-8a46-2ffd1b727822.png

— Reply to this email directly, view it on GitHub https://github.com/backspaces/agentscript/issues/80, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA6LTSZRQRINPZUV2CMUNLX2DLOXANCNFSM6AAAAAA4VPDJIE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

backspaces commented 12 months ago

Oops, it's already closed, so no worries.

On Sat, Nov 25, 2023 at 9:35 AM Owen Densmore @.***> wrote:

I think this is fixed. Could you try? If it's ok, close the issue, please.

On Tue, Sep 12, 2023 at 4:00 PM Stephen Guerin @.***> wrote:

example to reproduce: run: https://code.agentscript.org/maplibre/droplets.html

and check console:

[image: image] < https://user-images.githubusercontent.com/1078567/267475893-01ca3a54-e821-40ad-8a46-2ffd1b727822.png>

— Reply to this email directly, view it on GitHub https://github.com/backspaces/agentscript/issues/80, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAA6LTSZRQRINPZUV2CMUNLX2DLOXANCNFSM6AAAAAA4VPDJIE>

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/backspaces/agentscript/issues/80#issuecomment-1826372443, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA6LTXLAP27MYVUF2JVG4DYGIM5PAVCNFSM6AAAAAA4VPDJIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRWGM3TENBUGM . You are receiving this because you are subscribed to this thread.Message ID: @.***>