search

backstage-technical-services / hub

The starting place for anything related to the website.
0 stars 1 forks source link

Manifesto directories persist election deletion #93

Closed bnjns closed 4 years ago

bnjns commented 4 years ago

In GitLab by @jordanlkirk99 on Jun 16, 2019, 13:21

When an election is deleted, manifestos are deleted but their directory persists.

If the latest election is deleted and a new one created the ID is reused. At election creation a new directory is created using that ID, this fails as the directory already exists. [ A db rollback left the db IDs out of sync with those previously used and saved in the resources directory ]

[Tested on Windows]

bnjns commented 4 years ago

In GitLab by @jordanlkirk99 on Jun 16, 2019, 13:22

changed the description

bnjns commented 4 years ago

In GitLab by @jordanlkirk99 on Jun 16, 2019, 13:24

created branch feature/101-delete-manifesto-directories to address this issue

bnjns commented 4 years ago

In GitLab by @jordanlkirk99 on Jun 16, 2019, 13:32

Fix does not work retroactively, directories for previously deleted elections remain.

bnjns commented 4 years ago

In GitLab by @bnjns on Jun 16, 2019, 15:54

The actual problem is that the election ID shouldn't ever clash with a past entity.

bnjns commented 4 years ago

In GitLab by @jordanlkirk99 on Jun 16, 2019, 16:42

changed the description

bnjns commented 4 years ago

In GitLab by @jordanlkirk99 on Jun 16, 2019, 16:43

Sorry my bad, I've checked and they're not reused.

I had rolled back my db leaving the IDs out of sync with the directories.

However the directories still persist deletion.

bnjns commented 4 years ago

In GitLab by @jordanlkirk99 on Jun 16, 2019, 20:20

changed the description

bnjns commented 4 years ago

In GitLab by @bnjns on Jun 17, 2019, 20:16

Agreed. We should delete the parent directory too.

bnjns commented 4 years ago

In GitLab by @jordanlkirk99 on Jun 17, 2019, 21:41

mentioned in commit laravel-site@f8fbf67ddf0fc50d0254c500e01442f6f3c7d4ec

bnjns commented 4 years ago

In GitLab by @jordanlkirk99 on Jun 18, 2019, 00:52

assigned to @jordanlkirk99

bnjns commented 4 years ago

In GitLab by @jordanlkirk99 on Jul 21, 2019, 21:33

mentioned in merge request laravel-site!112

bnjns commented 4 years ago

In GitLab by @bnjns on Jul 22, 2019, 18:36

mentioned in commit laravel-site@e21c18f8df2900f9db266e7b11c3ce2ac9b75f2e

bnjns commented 4 years ago

In GitLab by @bnjns on Jul 22, 2019, 18:41

mentioned in merge request laravel-site!114

bnjns commented 4 years ago

In GitLab by @jordanlkirk99 on Jul 22, 2019, 18:42

closed via commit laravel-site@f8fbf67ddf0fc50d0254c500e01442f6f3c7d4ec

bnjns commented 4 years ago

In GitLab by @bnjns on Jul 22, 2019, 18:42

mentioned in commit laravel-site@3ded2c0436bbdfe615574d44b699a17537133dff

bnjns commented 4 years ago

In GitLab by @bnjns on Jul 22, 2019, 18:42

closed via merge request laravel-site!114