fix: email processor esm issue with p-throttle + config read

backstage / backstage

Backstage is an open framework for building developer portals

https://backstage.io/

Apache License 2.0

26.61k stars 5.46k forks source link

fix: email processor esm issue with p-throttle + config read #24582

Closed drodil closed 2 weeks ago

drodil commented 2 weeks ago

Hey, I just made a Pull Request!

Change the version to p-throttle where it's not a pure ESM module (like it is done for p-limit and p-queue already). Also, fixes the config reading from transport to transportConfig

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

backstage-goalie[bot] commented 2 weeks ago

Unexpected Changesets

The following changeset(s) reference packages that have not been changed in this PR:

.changeset/cyan-eagles-hammer.md: @backstage/plugin-notifications-backend

Note that only changes that affect the published package require changesets, for example changes to tests and storybook stories do not require changesets.

Changed Packages

Package Name	Package Path	Changeset Bump	Current Version
@backstage/plugin-notifications-backend-module-email	plugins/notifications-backend-module-email	patch	`v0.0.1-next.0`

github-actions[bot] commented 2 weeks ago

Uffizzi Cluster pr-24582 was deleted.

drodil commented 2 weeks ago

@Rugvip can we get a merge for this as @mareklibra is still on vacation? Probably some conflicts with other PRs so would be nice. Thanks!

github-actions[bot] commented 2 weeks ago

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.27.0 release, scheduled for Tue, 14 May 2024.