Closed ri-roee closed 4 months ago
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!
@ChrisJBurns sorry to tag you in this directly, but wanted to make sure you saw it as its marked stale! Would appreciate a review :)
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!
Description of the change
By default the
app-config.production.yaml
file is not used in bootup process of backstage. This leads to misconfiguration and confusion (see attached issue). This PR is a no-op for folks who continue to not setbackstage.environment
value, however those using theproduction
string will have the config correctly passed in.Existing or Associated Issue(s)
https://github.com/backstage/backstage/issues/25189
Additional Information
It is not strictly required to pass in
--config app-config.yaml
however I felt that being extra verbose would be clearer in this case.I noticed that the
ct install
tests were failing, even off master, and I believe this is due to the NODE_ENV not being set correctly thus causing the guest auth provider to error out. I now set that env var based on the backstage environmentChecklist
Chart.yaml
according to semver.values.yaml
and added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-run
to preview the content.ct lint
command.