feat: add support for multiple hosts and tls configurations in ingress

msoderberg commented 2 months ago

Description of the change

Adds ingress.extraHosts and ingress.extraTls which allows you to add extra host and tls items to the generated Ingress resource.

Existing or Associated Issue(s)

Additional Information

We run Backstage in EKS and are currently adding a condition annotation in the Ingress to configure the AWS ALB with an extra hostname. The downside with this approach is that we have to specify the AWS ACM certificate ARN:s for the domains (we loose the certificate discovery functionality).

There are other workarounds as well (e.g. using extraDeploy to create multiple Ingress resources), but having native support for multiple hosts in the Helm chart would simplify our life a bit.

Checklist

[x] Chart version bumped in Chart.yaml according to semver.
[x] Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
[x] JSON Schema generated.
[x] List tests pass for Chart using the Chart Testing tool and the ct lint command.

msoderberg commented 2 months ago

Linting chart "backstage => (version: \"1.10.0\", path: \"charts/backstage\")"
Checking chart "backstage => (version: \"1.10.0\", path: \"charts/backstage\")" for a version bump...
Old chart version: 1.9.6
New chart version: 1.10.0
Chart version ok.
Validating /home/marsod/git/backstage/charts/charts/backstage/Chart.yaml...
Validation success! 👍

Linting chart with values file "charts/backstage/ci/appConfig-values.yaml"...

==> Linting charts/backstage

1 chart(s) linted, 0 chart(s) failed

Linting chart with values file "charts/backstage/ci/default-values.yaml"...

==> Linting charts/backstage

1 chart(s) linted, 0 chart(s) failed

Linting chart with values file "charts/backstage/ci/extraDeploy-values.yaml"...

==> Linting charts/backstage

1 chart(s) linted, 0 chart(s) failed

Linting chart with values file "charts/backstage/ci/extraVolumes-values.yaml"...

==> Linting charts/backstage

1 chart(s) linted, 0 chart(s) failed

Linting chart with values file "charts/backstage/ci/image-digest-values.yaml"...

==> Linting charts/backstage

1 chart(s) linted, 0 chart(s) failed

Linting chart with values file "charts/backstage/ci/ingress-extraHosts-values.yaml"...

==> Linting charts/backstage

1 chart(s) linted, 0 chart(s) failed

Linting chart with values file "charts/backstage/ci/ingress-values.yaml"...

==> Linting charts/backstage

1 chart(s) linted, 0 chart(s) failed

Linting chart with values file "charts/backstage/ci/postgres-generated-creds-values.yaml"...

==> Linting charts/backstage

1 chart(s) linted, 0 chart(s) failed

Linting chart with values file "charts/backstage/ci/postgres-provided-creds-values.yaml"...

==> Linting charts/backstage

1 chart(s) linted, 0 chart(s) failed

Linting chart with values file "charts/backstage/ci/probes-values.yaml"...

==> Linting charts/backstage

1 chart(s) linted, 0 chart(s) failed
------------------------------------------------------------------------------------------------------------------------
 ✔︎ backstage => (version: "1.10.0", path: "charts/backstage")
------------------------------------------------------------------------------------------------------------------------
All charts linted successfull

github-actions[bot] commented 1 month ago

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

msoderberg commented 1 month ago

Still waiting for review so please keep it open.

github-actions[bot] commented 1 month ago

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

msoderberg commented 1 month ago

I think this is getting ready for merge. I just need a reply on my comment here: https://github.com/backstage/charts/pull/218#discussion_r1766257196

github-actions[bot] commented 3 weeks ago

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

backstage / charts