search

backstage / community-plugins

Community plugins for Backstage
Apache License 2.0
148 stars 157 forks source link

🚀 Entity Feedback Plugin: Providing multiple feedbacks per entity #449

Open mbrettschneider opened 4 months ago

mbrettschneider commented 4 months ago

Plugin Name

Entity Feedback Plugin

🔖 Feature description

It might be that a user wants to provide multiple feedbacks. Currently, the old feedback gets overwritten. Instead, it should be listed as an additional feedback.

🎤 Context

In my use-case, I would expect that entities could have multiple issues, found by one user in multiple usages of the entity.

✌️ Possible Implementation

No response

👀 Have you spent some time to check if this feature request has been raised before?

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

No, I don't have time to work on this right now

kuangp commented 4 months ago

Thanks for requesting this issue - I think it makes sense to allow this as an option for configuring this plugin.

I think this can be supported by making a simple change to the current ratings components: https://github.com/backstage/community-plugins/blob/ff24f6e6409ed2280b74e1978959b423d5e0fb62/workspaces/entity-feedback/plugins/entity-feedback/src/components/LikeDislikeButtons/LikeDislikeButtons.tsx#L72-L90 https://github.com/backstage/community-plugins/blob/ff24f6e6409ed2280b74e1978959b423d5e0fb62/workspaces/entity-feedback/plugins/entity-feedback/src/components/StarredRatingButtons/StarredRatingButtons.tsx#L71-L92

A component prop can probably be added to disable the hooks above - something like showPreviousRating = false, defaulted to true to preserve current behavior. This should allow a user to enter a new rating every time they visit the entity since the backend should already handle persisting each submission appropriately timestamped.

It should be a relatively straightforward change if someone is willing to contribute this enhancement 🙂

yashoswalyo commented 2 months ago

You might want to take a look at https://www.npmjs.com/package/@janus-idp/backstage-plugin-feedback

github-actions[bot] commented 2 days ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.