backstage / mkdocs-monorepo-plugin

✚ Build multiple documentation folders in a single Mkdocs. Designed for large codebases.
https://backstage.github.io/mkdocs-monorepo-plugin/
Apache License 2.0
314 stars 75 forks source link

Allow for spaces in site_name of sub-docs #56

Closed jaklan closed 2 years ago

jaklan commented 2 years ago

Hi, currently the plugin fails if any of sub-projects' site name include whitespaces. The assumption is to use that name just to generate an URL, because we show the root site name anyway, so whitespaces seem redundant. However:

Imho it can be fixed easily - instead of forbidding whitespaces, let's just replace them with underscores automatically by plugin when reading the config values. This way we don't introduce any breaking changes and we make the transition to monorepo even easier 😉

❯ mkdocs serve
INFO     -  Building documentation...
[mkdocs-monorepo] Site name can only contain letters, numbers, underscores, hyphens and forward-slashes. The regular expression we test against is '^[a-zA-Z0-9_\-/]+$'.
fmg-dave commented 2 years ago

+1

I would also like this feature.

camilaibs commented 2 years ago

Hello @jaklan and @fmg-dave do you still have the same problem after this pull request https://github.com/backstage/mkdocs-monorepo-plugin/pull/58 was merged?

Please let us know if we can close this issue 🙌🏻

soapraj commented 2 years ago

Closing this issue. Please re-open if needed.