search

backstage / mkdocs-monorepo-plugin

✚ Build multiple documentation folders in a single Mkdocs. Designed for large codebases.
https://backstage.github.io/mkdocs-monorepo-plugin/
Apache License 2.0
316 stars 74 forks source link

Add support for external links #7

Closed pjotr-gr closed 4 years ago

pjotr-gr commented 4 years ago

When an included mkdocs.yml contains an absolute url the resulting url will be incorrect as it gets the alias prefixed to it breaking the url. This fix does not touch such urls and they will work properly.

bih commented 4 years ago

This looks great. Can you add a test to ensure this functionality doesn't break in the future? It should be easy as we adopt black box testing for our tests.

bih commented 4 years ago

Another comment: Could you bump up the version and add a note in the changelog in docs/changelog.md?

pjotr-gr commented 4 years ago

Hello Bilal,

I did a commit and push containing a unittest and new line in docs/changelog.md I mentioned version 0.4.4 as I saw a branch 0.4.3 o GitHub.  I am not sure all went well as I am quite new to Git

With kind regards Peter On Wednesday, 20 November 2019, 15:12:20 CET, Bilawal Hameed notifications@github.com wrote:

Another comment: Could you bump up the version and add a note in the changelog in docs/changelog.md?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

bih commented 4 years ago

Closed as duplicate of #8