search

backstage / mkdocs-monorepo-plugin

✚ Build multiple documentation folders in a single Mkdocs. Designed for large codebases.
https://backstage.github.io/mkdocs-monorepo-plugin/
Apache License 2.0
314 stars 75 forks source link

Fix page edit url #74

Closed camilaibs closed 2 years ago

camilaibs commented 2 years ago

Refs: https://github.com/backstage/mkdocs-monorepo-plugin/issues/45

Fix edit URL for nested pages.

How to test?

  1. Checkout to this branch
  2. Access the test directory 
    cd __tests__/integration/fixtures/bug-include-path-edit-uri
  3. Build documentation using mkdocs 
    mkdocs build
  4. Inspect the index.html and test/index.html generated in the site folder
camilaibs commented 2 years ago

👏 👏 👏 So excited for this to finally be fixed! Nice work, @camilaibs.

In testing, I found one possible bug (see diff in the comments). Remaining comments are minor test / code organization ideas.

Hi @iamEAP, thanks again for reviewing these changes. This pull request is ready for review again when you have time 🙂