Leave absolute urls untouched in included mkdocs.yml

backstage / mkdocs-monorepo-plugin

✚ Build multiple documentation folders in a single Mkdocs. Designed for large codebases.

https://backstage.github.io/mkdocs-monorepo-plugin/

Apache License 2.0

316 stars 74 forks source link

Leave absolute urls untouched in included mkdocs.yml #8

Closed pjotr-gr closed 2 years ago

pjotr-gr commented 4 years ago

Hello Bilawal ,

I have attached a unittest and a entry in CHANGELOG.md. The target version I mentioned is 0.4.4 can be different of course. Thank you for the plugin.

mkdocs-monorepo-plugin/mkdocs_monorepo_plugin/parser.py mkdocs-monorepo-plugin/tests/integration/test.bats mkdocs-monorepo-plugin/tests/integration/fixtures/include-path-absolute-url/ mkdocs-monorepo-plugin/docs/Changelog.md

With kind regards

Peter

bih commented 4 years ago

Thanks for this contribution. I added a few comments, but overall looking great and close to being merged!

pjotr-gr commented 4 years ago

Thank you, Regards Peter Sent from Yahoo Mail on Android

On Fri, 22 Nov 2019 at 15:24, Bilawal Hameednotifications@github.com wrote:
Thanks for this contribution. I added a few comments, but overall looking great and close to being merged!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

pjotr-gr commented 4 years ago

I finished the review. What i do not unsterstand is the failing unittests. Locally all tests run fine.

wilhelmer commented 3 years ago

Could we get this merged anytime soon, please? Not being able to use external links in any of the submodules' navigations is a pretty big drawback for us.

camilaibs commented 2 years ago

Closing in favor of #60