backstage / mkdocs-monorepo-plugin

✚ Build multiple documentation folders in a single Mkdocs. Designed for large codebases.
https://backstage.github.io/mkdocs-monorepo-plugin/
Apache License 2.0
319 stars 74 forks source link

Fix incompatibility with mkdocs v1.4.0 #86

Closed iamEAP closed 2 years ago

iamEAP commented 2 years ago

What / Why

Looks like this change, released in mkdocs v1.4.0 slightly changed the way the edit_uri config behaves when it is not set. ...A small change will allow us to support this again.

How to test

  1. Manually update requirements.txt to use mkdocs>=1.4.0
  2. Run the test suite locally PYTHON_37_ONLY=1 ./__tests__/test-local.sh

Without the change to edit_uri.py, the test suite should fail numerous cases. With the change, all tests should pass.