backstage / mkdocs-techdocs-core

The core MkDocs plugin used by Backstage's TechDocs as a wrapper around multiple MkDocs plugins and Python Markdown extensions
Apache License 2.0
82 stars 61 forks source link

chore(renovate): refactor config file #179

Closed MindTooth closed 1 month ago

MindTooth commented 3 months ago

I noticed the config was old and could need a update:

$ renovate-config-validator renovate.json5

 INFO: Validating renovate.json5
 WARN: Config migration necessary
       "oldConfig": {
         "labels": ["dependencies"],
         "extends": ["config:base", ":disableDependencyDashboard", ":gitSignOff"],
         "ignoreDeps": ["mkdocs-material"],
         "packageRules": [{"matchLanguages": ["python"], "rangeStrategy": "widen"}]
       },
       "newConfig": {
         "labels": ["dependencies"],
         "extends": [
           "config:recommended",
           ":disableDependencyDashboard",
           ":gitSignOff"
         ],
         "ignoreDeps": ["mkdocs-material"],
         "packageRules": [{"matchCategories": ["python"], "rangeStrategy": "widen"}]
       }
 INFO: Config validated successfully

Question? One question, now that we are on the latest mkdocs-material, should we then remove the ignore and rather split on major/minor so that updates will still be added? Or we can limit updates within the same x.y.


With the changes:

$ renovate-config-validator .github/renovate.json

 INFO: Validating .github/renovate.json
 INFO: Config validated successfully
MindTooth commented 3 months ago

@johnphilip283 thoughts?

johnphilip283 commented 3 months ago

Hey there @MindTooth! Thank you for the PR. We'd like to be on the safer side with mkdocs-material upgrades, so I believe limiting updates within the same x.y would be a nice way to do this. Otherwise, the rest of the changes LGTM!

MindTooth commented 3 months ago

I've updated the config to use allowedVersions to limit the range.

github-actions[bot] commented 2 months ago

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] commented 2 months ago

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

MindTooth commented 2 months ago

@johnphilip283 need anything more from me? :smile:

github-actions[bot] commented 1 month ago

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

MindTooth commented 1 month ago

Feel like I'm in a whack-a-mole game with the Stale bot. 🤣

whack-a-mole gif