search

backstage / mkdocs-techdocs-core

The core MkDocs plugin used by Backstage's TechDocs as a wrapper around multiple MkDocs plugins and Python Markdown extensions
Apache License 2.0
85 stars 61 forks source link

Upgrade plantuml-markdown to 3.4.2 #18

Closed Crevil closed 3 years ago

Crevil commented 3 years ago

The plantuml-markdown module has received a handful of bug fixes and new features. This change upgrades it to the latest version available.

Notable changes are the possibility for including plantuml files from files introduced in 3.3.0.

Complete changelog available here: https://github.com/mikitex70/plantuml-markdown/blob/master/CHANGELOG.md

Crevil commented 3 years ago

Looks like a GitHub token is missing for the Triage check...

https://github.com/backstage/mkdocs-techdocs-core/pull/18/checks?check_run_id=2093830056#step:3:8

OrkoHunter commented 3 years ago

Sure! Could you follow the steps here to helps us make a release with this PR? https://github.com/backstage/mkdocs-techdocs-core#release-flow

Yeah the triaging doesn't work for PRs created from forks due to GitHub token not being shared. sad

Crevil commented 3 years ago

@OrkoHunter updated the changelog. Testing it locally it seems I needed to update the plantuml-markdown version in setup.py as well. I'm not familiar with Pyton so let me know if updating that field was a mistake.

OrkoHunter commented 3 years ago

Oh no, we have duplicated dependencies list. :/ Should just keep requirements.txt and re-use it.

But thanks for updating there as well!