search

backstage / mkdocs-techdocs-core

The core MkDocs plugin used by Backstage's TechDocs as a wrapper around multiple MkDocs plugins and Python Markdown extensions
Apache License 2.0
82 stars 61 forks source link

Update requirements.txt to allow plantuml-markdown 3.9.3 #181

Closed nickboldt closed 2 months ago

nickboldt commented 3 months ago

There is now a plantuml-markdown 3.9.3, and without this proposed change, I cannot co-install these:

as the following error is thrown:

[
  "RequirementInformation(requirement=SpecifierRequirement('plantuml-markdown==3.9.3')",
  "parent=None)",
  "RequirementInformation(requirement=SpecifierRequirement('plantuml-markdown==3.9.2')",
  "parent=LinkCandidate('https://files.pythonhosted.org/packages/b1/14/00c84cda0fc45169e936157ff5a79db22d4f3206df611975f630ffef3f22/mkdocs_techdocs_core-1.3.5-py3-none-any.whl (from https://pypi.org/simple/mkdocs-techdocs-core/) (requires-python:>=3.7)'))"
]
nickboldt commented 3 months ago

@johnphilip283 Can you have a look at this fix?

Related: https://github.com/backstage/mkdocs-techdocs-core/pull/182

johnphilip283 commented 3 months ago

Hey @nickboldt! Thanks for opening this up. In general, we'd like to avoid open-ended version ranges in order to make stability a bit easier to guarantee - but I've merged the upgrade for 3.9.4 for plantuml-markdown to unblock you. Let me know if this solves what you're after!

github-actions[bot] commented 2 months ago

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!