backstage / mkdocs-techdocs-core

The core MkDocs plugin used by Backstage's TechDocs as a wrapper around multiple MkDocs plugins and Python Markdown extensions
Apache License 2.0
85 stars 61 forks source link

Updated setup.py #24

Closed iamansoni closed 3 years ago

iamansoni commented 3 years ago

Closes #19

Reused data from requirements.txt in install_requires of setup.py

emmaindal commented 3 years ago

Thank you @iamansoni for contributing with this change. I can see the linter is not happy, if you can look into that it would be great and then also add a one-liner in the changelog as well as a version bump in setup.py and we are ready to merge this!

iamansoni commented 3 years ago

I don't know why I'm still receiving the black lint issue; I've checked it on my local system and the code turns out to be working fine over there.

s1

emmaindal commented 3 years ago

I don't know why I'm still receiving the black lint issue; I've checked it on my local system and the code turns out to be working fine over there.

s1

Seems like it was just a few spaces that caused the issue. I pushed an update so it should be ready to get merged. Thank you for the contribution 🎉