Simplify how the theme is override

backstage / mkdocs-techdocs-core

The core MkDocs plugin used by Backstage's TechDocs as a wrapper around multiple MkDocs plugins and Python Markdown extensions

Apache License 2.0

83 stars 61 forks source link

Simplify how the theme is override #67

Closed aladjadj closed 2 years ago

aladjadj commented 2 years ago

This PR intends to simplify the code to update only the attribute necessary by backstage

Nota: Previously, this PR tried to fix the run-time error fixed by #69

aladjadj commented 2 years ago

It's necessary to add tests to validate that, I add them when I've some time

aladjadj commented 2 years ago

Thx for your fix and comments and my apologize for the introduced bug.

If the theme config is all the time an instance of Theme and we want to keep the capability to override this in mkdocs, we can just update the field we want ?

aladjadj commented 2 years ago

Thx for your help @iamEAP , i follow your different feedback to improve the PR.